commit c0312c10e6743366e8a99029042abf52d1af1e53
author George Keishing <gkeishin@in.ibm.com> Thu May 08 23:02:25 2025 +0530
committer George Keishing <gkeishin@in.ibm.com> Thu May 08 23:58:45 2025 +0530
tree 6a5ed30717a382d9590219f740e9e41236e8829c
parent a68c5ae4f846262b438d77e44b64a3faefa84a91

Update tox.ini default parameters

The default password is now set to empty.
User are expected to pass the password when
running the test.

Changes:
   - Removed OPENBMC_PASSWORD from tox.ini
   - Update python to python3
   - global ipmi_required_options is unused:
     name is never assigned in scope

Tested:
   - Ran from the sandbox with the changes

Change-Id: I1f14b8c725957700dcd42a892c462888306c0a91
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

lib/ipmi_client.py

diff --git a/lib/ipmi_client.py b/lib/ipmi_client.py
index 6fffe2c..87b2618 100644
--- a/lib/ipmi_client.py
+++ b/lib/ipmi_client.py
@@ -96,7 +96,6 @@
     """
 
     # Assumption: "U" is in the global ipmi_required_options.
-    global ipmi_required_options
     print_output = 0
 
     command_string = create_ipmi_ext_command_string("power status")

tox.ini

diff --git a/tox.ini b/tox.ini
index 5b27dc6..84d150a 100644
--- a/tox.ini
+++ b/tox.ini
@@ -5,7 +5,6 @@
 passenv = *
 setenv =
     ARG_FILE={envtmpdir}/argument_file.txt
-    OPENBMC_PASSWORD=0penBmc
     OPENBMC_USERNAME=root
     SYSLOG_IP_ADDRESS=127.0.0.1
     SYSLOG_PORT=514
@@ -25,7 +24,7 @@
 setenv = {[testenv]setenv}
 commands =
     {[testenv]commands}
-    python -m robot.run --argumentfile {env:ARG_FILE} {posargs}
+    python3 -m robot.run --argumentfile {env:ARG_FILE} {posargs}
 
 
 [testenv:palmetto]
@@ -34,7 +33,7 @@
     OPENBMC_MODEL=./data/Palmetto.py
 commands =
     {[testenv]commands}
-    python -m robot.run --argumentfile {env:ARG_FILE} {posargs}
+    python3 -m robot.run --argumentfile {env:ARG_FILE} {posargs}
 
 
 [testenv:qemu]
@@ -43,7 +42,7 @@
     OPENBMC_MODEL=./data/Palmetto.py
 commands =
     {[testenv]commands}
-    python -m robot.run --argumentfile {env:ARG_FILE} {posargs}
+    python3 -m robot.run --argumentfile {env:ARG_FILE} {posargs}
 
 
 [testenv:witherspoon]
@@ -52,7 +51,7 @@
     OPENBMC_MODEL=./data/Witherspoon.py
 commands =
     {[testenv]commands}
-    python -m robot.run --argumentfile {env:ARG_FILE} {posargs}
+    python3 -m robot.run --argumentfile {env:ARG_FILE} {posargs}
 
 [testenv:romulus]
 deps     = {[testenv]deps}
@@ -60,4 +59,4 @@
     OPENBMC_MODEL=./data/Romulus.py
 commands =
     {[testenv]commands}
-    python -m robot.run --argumentfile {env:ARG_FILE} {posargs}
+    python3 -m robot.run --argumentfile {env:ARG_FILE} {posargs}