tree bdecd6442eba2bc492dc70af23a931cb09b79d47
parent 88064f0d61a8ff8f28cee73caa094f3325abb5ae
author Marri Devender Rao <devenrao@in.ibm.com> 1566461762 -0500
committer Andrew Geissler <geissonator@yahoo.com> 1567707261 +0000

Validate the certificate type and service values

In OP930 certificate type and service values are used to compute
the certifiate URL, any mismatch in the values used to result in
Invalid D-Bus path error.

In OP940 only certificate type is used in computing the Redfish
url and service value is ignored. But allowing the user to pass
service for backward compatability.

In OP940 as serivce value is not used, no validation is done to
check if certificate type and service are related leading to
confusion. Modified to add the validation.

listed below are the valid combinations of certificate type and
service values.
"server" and "https"
"client" and "ldap",
"autority" and "ldap"

Tested
$ python openbmctool.py -H $bmc -U user1 -P password1 certificate update server
ldap -f cert.pem
Attempting login...
Invalid service type
User user1 has been logged out
$ python openbmctool.py -H $bmc -U user1 -P password1 certificate update client
https -f cert.pem
Attempting login...
Invalid service type
User user1 has been logged out
$ python openbmctool.py -H $bmc -U user1 -P password1 certificate update
authority https -f cert.pem
Attempting login...
Invalid service type
User user1 has been logged out
$ python openbmctool.py -H $bmc -U user1 -P password1 certificate update
authority ldap -f cert.pem
Attempting login...
Update complete.
None
User user1 has been logged out

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I64dccca42391dca583fd0b2b8b612aff3b3970c3