Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openbmc-tools / a296b776e770251cc1f685135535f650a179b004
commita296b776e770251cc1f685135535f650a179b004[log] [tgz]
authorSui Chen <suichen@google.com>Sun Aug 14 11:56:30 2022 -0700
committerSui Chen <suichen@google.com>Sun Aug 14 12:22:59 2022 -0700
tree65c1145850975439f461a0e1ec1261282dda92fa
parent13339f0966b4eee1766a12e5d5ed9bf14800c986 [diff]
dbus-top: use mvwaddstr when no arguments are needed

Currently, some of the code uses mvwprintw to print a string without
using a format string, this causes the following errors:

error: format not a string literal and no format arguments
[-Werror=format-security]

The fix is to use mvwaddstr when no arguments are needed.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: Ib17ad7a7795cb7bf77161f8730139f38216b7aba
3 files changed
tree: 65c1145850975439f461a0e1ec1261282dda92fa
  1. adcapp/
  2. altitude/
  3. autojson/
  4. bbdbg/
  5. bi2cp/
  6. cla-signers/
  7. dbus-pcap/
  8. dbus-top/
  9. dbus-vis/
  10. dbus_sensor_tester/
  11. dbusView/
  12. ddconvnotrunc/
  13. expectedJsonChecker/
  14. format-yaml/
  15. maintainers/
  16. netboot/
  17. openbmc-autobump/
  18. openbmc-events/
  19. openbmctool/
  20. overlay/
  21. pldm/
  22. prepare-emmc-qemu/
  23. pretty-journal/
  24. pwmtachtool/
  25. reboot/
  26. reboot-ping-pong/
  27. rootfs_size/
  28. sensor_yaml_config/
  29. tof-voters/
  30. tracing/
  31. upload_and_update/
  32. witherspoon-debug/
  33. LICENSE
  34. OWNERS
  35. README.md
README.md

The OpenBMC Tools Collection

The goal of this repository is to collect the two-minute hacks you write to automate interactions with OpenBMC systems.

It's highly likely the scripts don't meet your needs - they could be undocumented, dysfunctional or utterly broken. Please help us improve!

Repository Rules

  • Always inspect what you will be executing
  • Some hacking on your part is to be expected

If you're still with us

Then this repository aims to be the default destination for your otherwise un-homed scripts. As such we are setting the bar for submission pretty low, and we aim to make the process as easy as possible.

Sending patches

Please use gerrit for all patches to this repository:

Do note that you will need to be party to the OpenBMC CLA before your contributions can be accepted. See Gerrit Setup and CLA for more information.

What we will do once we have your patches

So long as your patches look sane with a cursory glance you can expect them to be applied. We may push back in the event that similar tools already exist or there are egregious issues.

What you must have in your patches

We don't ask for much, but you need to give us at least a Signed-off-by, use SPDX markers in your source files and put your work under an Apache 2.0 compatible license.

How you consume the repository

There's no standard way to install the scripts housed here, and adding parts of the repository to your PATH might be a bit of a dice-roll. We may also move or remove scripts from time to time as part of housekeeping. It's probably best to copy things out if you need stability.