Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openbmc-tools / b53fa1b8603315858431af393b0022a933acf8cf
commitb53fa1b8603315858431af393b0022a933acf8cf[log] [tgz]
authorSui Chen <suichen@google.com>Thu May 26 00:16:42 2022 -0700
committerAndrew Jeffery <andrew@aj.id.au>Thu Jun 02 01:24:00 2022 +0000
tree71c70abab654e2fb39c744606ce606963e5c1cde
parentb3ef7f2b4419d818427612584c579e7534ceb460 [diff]
dbus-vis: Use IPC for open file dialog

Previously, the "open file" dialog is opened in the renderer thread
running "initialization.js".

This change moves the dialog to the main thread (main.js) so that the
renderer thread emits a "file-request" request and the main thread
answers with a "filename" response.

This IPC paradigm is required for newer versions of Electron, because
the "dialog" module cannot be imported in renderer threads in those
newer versions.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: Ifd324688bb8a4dbdc6a5f86082fb3d205af0d77a
3 files changed
tree: 71c70abab654e2fb39c744606ce606963e5c1cde
  1. adcapp/
  2. altitude/
  3. autojson/
  4. bbdbg/
  5. bi2cp/
  6. cla-signers/
  7. dbus-pcap/
  8. dbus-vis/
  9. dbus_sensor_tester/
  10. dbusView/
  11. ddconvnotrunc/
  12. expectedJsonChecker/
  13. format-yaml/
  14. maintainers/
  15. netboot/
  16. openbmc-autobump/
  17. openbmc-events/
  18. openbmctool/
  19. overlay/
  20. pldm/
  21. prepare-emmc-qemu/
  22. pretty-journal/
  23. pwmtachtool/
  24. reboot/
  25. reboot-ping-pong/
  26. rootfs_size/
  27. sensor_yaml_config/
  28. tof-voters/
  29. tracing/
  30. upload_and_update/
  31. witherspoon-debug/
  32. LICENSE
  33. MAINTAINERS
  34. README.md
README.md

The OpenBMC Tools Collection

The goal of this repository is to collect the two-minute hacks you write to automate interactions with OpenBMC systems.

It's highly likely the scripts don't meet your needs - they could be undocumented, dysfunctional or utterly broken. Please help us improve!

Repository Rules

  • Always inspect what you will be executing
  • Some hacking on your part is to be expected

If you're still with us

Then this repository aims to be the default destination for your otherwise un-homed scripts. As such we are setting the bar for submission pretty low, and we aim to make the process as easy as possible.

Sending patches

Please use gerrit for all patches to this repository:

Do note that you will need to be party to the OpenBMC CLA before your contributions can be accepted. See Gerrit Setup and CLA for more information.

What we will do once we have your patches

So long as your patches look sane with a cursory glance you can expect them to be applied. We may push back in the event that similar tools already exist or there are egregious issues.

What you must have in your patches

We don't ask for much, but you need to give us at least a Signed-off-by, use SPDX markers in your source files and put your work under an Apache 2.0 compatible license.

How you consume the repository

There's no standard way to install the scripts housed here, and adding parts of the repository to your PATH might be a bit of a dice-roll. We may also move or remove scripts from time to time as part of housekeeping. It's probably best to copy things out if you need stability.