Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openbmc / 2f714db14e994f0bb4cd412e1dd4526c2c517e25
commit2f714db14e994f0bb4cd412e1dd4526c2c517e25[log] [tgz]
authorAlexander Filippov <a.filippov@yadro.com>Fri Nov 23 16:04:49 2018 +0300
committerBrad Bishop <bradleyb@fuzziesquirrel.com>Wed Nov 28 09:45:18 2018 -0500
treec48234da48ad494fbe7dabed3c97a8a4462ba93d
parent01f149c02c90389f51f2c4eaf5519f9bf2aa57d0 [diff]
Fix the starting of phosphor-hwmon

After the commit 7ead6495b6d6782dd89951e8bfb26131f35863ec
the phosphor-hwmon failed to start with errors like this:
```
/lib/systemd/system/xyz.openbmc_project.Hwmon@.service:8:
  Failed to resolve unit specifiers on %f: Invalid argument
```

It happens when the instance name begins with `/` character which causes
this error when used specifier `%f`.

Besides the specifier `%I` looks less buggy and more appropriate in this
case, because it's the only part of path and will be completed inside
the `phosphor-hwmon-readd`.

This commit fixes the starting of the phosphor-hwmon.

Partially resolves: openbmc/openbmc#3435

(From meta-phosphor rev: a87fb2d1eb682ed0f04e0f269966b9ae4aafbb1e)

Change-Id: Ia8185f047f23bdcd9141d7edea47ad50e6f7fe07
Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
2 files changed
tree: c48234da48ad494fbe7dabed3c97a8a4462ba93d
  1. meta-arm/
  2. meta-aspeed/
  3. meta-evb/
  4. meta-facebook/
  5. meta-google/
  6. meta-hxt/
  7. meta-ibm/
  8. meta-ingrasys/
  9. meta-intel/
  10. meta-inventec/
  11. meta-mellanox/
  12. meta-nuvoton/
  13. meta-openembedded/
  14. meta-openpower/
  15. meta-phosphor/
  16. meta-portwell/
  17. meta-qualcomm/
  18. meta-quanta/
  19. meta-raspberrypi/
  20. meta-security/
  21. meta-x86/
  22. meta-xilinx/
  23. poky/
  24. bitbake ⇨ poky/bitbake/
  25. LICENSE ⇨ poky/LICENSE
  26. meta ⇨ poky/meta
  27. meta-poky ⇨ poky/meta-poky/
  28. meta-skeleton ⇨ poky/meta-skeleton
  29. oe-init-build-env ⇨ poky/oe-init-build-env
  30. scripts ⇨ poky/scripts/
  31. .gitignore
  32. .gitreview
  33. .templateconf
  34. MAINTAINERS
  35. openbmc-env
  36. README.md
  37. setup
README.md

OpenBMC

Build Status

The OpenBMC project can be described as a Linux distribution for embedded devices that have a BMC; typically, but not limited to, things like servers, top of rack switches or RAID appliances. The OpenBMC stack uses technologies such as Yocto, OpenEmbedded, systemd, and D-Bus to allow easy customization for your server platform.

Setting up your OpenBMC project

1) Prerequisite

  • Ubuntu 14.04
sudo apt-get install -y git build-essential libsdl1.2-dev texinfo gawk chrpath diffstat
  • Fedora 28
sudo dnf install -y git patch diffstat texinfo chrpath SDL-devel bitbake rpcgen
sudo dnf groupinstall "C Development Tools and Libraries"

2) Download the source

git clone git@github.com:openbmc/openbmc.git
cd openbmc

3) Target your hardware

Any build requires an environment variable known as TEMPLATECONF to be set to a hardware target. You can see all of the known targets with find meta-* -name local.conf.sample. Choose the hardware target and then move to the next step. Additional examples can be found in the OpenBMC Cheatsheet

MachineTEMPLATECONF
Palmettometa-ibm/meta-palmetto/conf
Zaiusmeta-ingrasys/meta-zaius/conf
Witherspoonmeta-ibm/meta-witherspoon/conf
Romulusmeta-ibm/meta-romulus/conf

As an example target Palmetto

export TEMPLATECONF=meta-ibm/meta-palmetto/conf

4) Build

. openbmc-env
bitbake obmc-phosphor-image

Additional details can be found in the docs repository.

Build Validation and Testing

Commits submitted by members of the OpenBMC GitHub community are compiled and tested via our Jenkins server. Commits are run through two levels of testing. At the repository level the makefile make check directive is run. At the system level, the commit is built into a firmware image and run with an arm-softmmu QEMU model against a barrage of CI tests.

Commits submitted by non-members do not automatically proceed through CI testing. After visual inspection of the commit, a CI run can be manually performed by the reviewer.

Automated testing against the QEMU model along with supported systems are performed. The OpenBMC project uses the Robot Framework for all automation. Our complete test repository can be found here.

Submitting Patches

Support of additional hardware and software packages is always welcome. Please follow the contributing guidelines when making a submission. It is expected that contributions contain test cases.

Bug Reporting

Issues are managed on GitHub. It is recommended you search through the issues before opening a new one.

Features of OpenBMC

Feature List

  • REST Management
  • IPMI
  • SSH based SOL
  • Power and Cooling Management
  • Event Logs
  • Zeroconf discoverable
  • Sensors
  • Inventory
  • LED Management
  • Host Watchdog
  • Simulation
  • Code Update Support for multiple BMC/BIOS images
  • POWER On Chip Controller (OCC) Support

Features In Progress

  • Full IPMI 2.0 Compliance with DCMI
  • Verified Boot
  • HTML5 Java Script Web User Interface
  • BMC RAS

Features Requested but need help

  • OpenCompute Redfish Compliance
  • OpenBMC performance monitoring
  • cgroup user management and policies
  • Remote KVM
  • Remote USB
  • OpenStack Ironic Integration
  • QEMU enhancements

Finding out more

Dive deeper in to OpenBMC by opening the docs repository.

Contact