| From 94fe6eb9ea2691f4a7c32fbf2d0c7c454995b666 Mon Sep 17 00:00:00 2001 |
| From: Changqing Li <changqing.li@windriver.com> |
| Date: Thu, 27 Feb 2020 11:08:57 +0800 |
| Subject: [PATCH] Fix #587 |
| |
| Off by one error in common.c, CVE-2019-19906. |
| |
| Thanks to Stephan Zeisberg for reporting |
| |
| CVE: CVE-2019-19906 |
| |
| Upstream-Stauts: Backport [https://github.com/cyrusimap/cyrus-sasl |
| /commit/dcc9f51cbd4ed622cfb0f9b1c141eb2ffe3b12f1] |
| |
| Signed-off-by: Changqing Li <changqing.li@windriver.com> |
| --- |
| lib/common.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/lib/common.c b/lib/common.c |
| index d9104c8..fef82db 100644 |
| --- a/lib/common.c |
| +++ b/lib/common.c |
| @@ -190,7 +190,7 @@ int _sasl_add_string(char **out, size_t *alloclen, |
| |
| if (add==NULL) add = "(null)"; |
| |
| - addlen=strlen(add); /* only compute once */ |
| + addlen=strlen(add)+1; /* only compute once */ |
| if (_buf_alloc(out, alloclen, (*outlen)+addlen+1)!=SASL_OK) |
| return SASL_NOMEM; |
| |
| -- |
| 2.25.1 |
| |