)]}' { "commit": "b1ff1bd2067beed2425de13d4d75beb0fbe2dc17", "tree": "5ede129e3dcd8de9fc4be93578156344f4cfbda2", "parents": [ "6da0524cb61888039bd5960461904e8c4c21f5da" ], "author": { "name": "Joel Stanley", "email": "joel@jms.id.au", "time": "Thu Feb 25 14:03:26 2021 +1030" }, "committer": { "name": "Joel Stanley", "email": "joel@jms.id.au", "time": "Mon Mar 01 04:53:39 2021 +0000" }, "message": "Remove phsophor-gpio-keys as a standalone feature\n\nThe feature was implemented as an append to the kernel (BSP) layers in\nmeta-phsophor. This created a three way dance between machine layers,\nBSP and meta-phosphor, when it should have been the kernel layer\nproviding this feature and machines could then opt in.\n\nFixing this means we could remove the KERNEL_DANGLING_FEATURES_WARN_ONLY\nworkaround.\n\nAs the feature is simply turning on a pair of kernel options without any\nother impact, we can implement it by adding the options to our\ndefconfigs. In fact, aspeed and hpe kernel configurations enable the two\nkernel options:\n\n$ git grep CONFIG_KEYBOARD_GPIO\u003dy\nmeta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g4/defconfig:CONFIG_KEYBOARD_GPIO\u003dy\nmeta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g5/defconfig:CONFIG_KEYBOARD_GPIO\u003dy\nmeta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g6/defconfig:CONFIG_KEYBOARD_GPIO\u003dy\nmeta-hpe/meta-gxp/recipes-kernel/linux/linux-obmc/defconfig:CONFIG_KEYBOARD_GPIO\u003dy\n\n$ git grep CONFIG_INPUT_EVDEV\nmeta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g4/defconfig:CONFIG_INPUT_EVDEV\u003dy\nmeta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g5/defconfig:CONFIG_INPUT_EVDEV\u003dy\nmeta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g6/defconfig:CONFIG_INPUT_EVDEV\u003dy\nmeta-hpe/meta-gxp/recipes-kernel/linux/linux-obmc/defconfig:CONFIG_INPUT_EVDEV\u003dy\n\nOther machines that wish to enable this feature should ensure it is\nadded to their BSP\u0027s defconfig, or add it to their machine specific\ndefconfig.\n\nChange-Id: I0726836319022f96c1d13d4a0cbd73708047302c\nSigned-off-by: Joel Stanley \u003cjoel@jms.id.au\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "0fcb9711dbd30fb6b8740c8d0abdff73cac870bd", "old_mode": 33188, "old_path": "meta-evb/meta-evb-enclustra/meta-evb-zx3-pm3/conf/machine/evb-zx3-pm3.conf", "new_id": "62716cd4200a98850af43adcfe8ae4c628cb90ce", "new_mode": 33188, "new_path": "meta-evb/meta-evb-enclustra/meta-evb-zx3-pm3/conf/machine/evb-zx3-pm3.conf" }, { "type": "delete", "old_id": "f5c01bed727278ad01e4b9e57e09e4b0bbc4fdd5", "old_mode": 33188, "old_path": "meta-hpe/meta-gxp/recipes-kernel/linux/linux-obmc/phosphor-gpio-keys.cfg", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "78961af7a2d087971d17c41e67c6a461743f4698", "old_mode": 33188, "old_path": "meta-hpe/meta-gxp/recipes-kernel/linux/linux-obmc/phosphor-gpio-keys.scc", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "8f5a627ede55a6dc0d332630eb3a9c9dcfff744b", "old_mode": 33188, "old_path": "meta-hpe/meta-gxp/recipes-kernel/linux/linux-obmc_5.7.bb", "new_id": "0e57afd8755235b632c872f358249230c2b8a1c1", "new_mode": 33188, "new_path": "meta-hpe/meta-gxp/recipes-kernel/linux/linux-obmc_5.7.bb" }, { "type": "modify", "old_id": "2eb7f58791e806c79055855c9f3e55e992d4c579", "old_mode": 33188, "old_path": "meta-ibm/meta-fsp2/recipes-kernel/linux/linux-fsp2.inc", "new_id": "37ae6abeb758fc1469762ec2bb15eeabd57313d9", "new_mode": 33188, "new_path": "meta-ibm/meta-fsp2/recipes-kernel/linux/linux-fsp2.inc" }, { "type": "delete", "old_id": "f5c01bed727278ad01e4b9e57e09e4b0bbc4fdd5", "old_mode": 33188, "old_path": "meta-phosphor/aspeed-layer/recipes-kernel/linux/linux-aspeed/phosphor-gpio-keys.cfg", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "78961af7a2d087971d17c41e67c6a461743f4698", "old_mode": 33188, "old_path": "meta-phosphor/aspeed-layer/recipes-kernel/linux/linux-aspeed/phosphor-gpio-keys.scc", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "7401a189565fcd6dfbda9829d78bcd7001e836c5", "old_mode": 33188, "old_path": "meta-phosphor/aspeed-layer/recipes-kernel/linux/linux-aspeed_%.bbappend", "new_id": "d8bbccfac322990f62701c643692d5093b89a364", "new_mode": 33188, "new_path": "meta-phosphor/aspeed-layer/recipes-kernel/linux/linux-aspeed_%.bbappend" }, { "type": "modify", "old_id": "b1b3885c4b09f049f458511c9dcca3ba6409fba7", "old_mode": 33188, "old_path": "meta-phosphor/conf/distro/include/phosphor-base.inc", "new_id": "af2e6ef76ebcce83cba5e8ead3b0c3f302b4ca88", "new_mode": 33188, "new_path": "meta-phosphor/conf/distro/include/phosphor-base.inc" }, { "type": "delete", "old_id": "f5c01bed727278ad01e4b9e57e09e4b0bbc4fdd5", "old_mode": 33188, "old_path": "meta-phosphor/nuvoton-layer/recipes-kernel/linux/linux-nuvoton/phosphor-gpio-keys.cfg", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "78961af7a2d087971d17c41e67c6a461743f4698", "old_mode": 33188, "old_path": "meta-phosphor/nuvoton-layer/recipes-kernel/linux/linux-nuvoton/phosphor-gpio-keys.scc", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "3d0bbb7f31a2757371dbed54535a2bf82b60ae68", "old_mode": 33188, "old_path": "meta-phosphor/nuvoton-layer/recipes-kernel/linux/linux-nuvoton_%.bbappend", "new_id": "e73d00f55a72793cb718dc038f16035783025288", "new_mode": 33188, "new_path": "meta-phosphor/nuvoton-layer/recipes-kernel/linux/linux-nuvoton_%.bbappend" }, { "type": "delete", "old_id": "f5c01bed727278ad01e4b9e57e09e4b0bbc4fdd5", "old_mode": 33188, "old_path": "meta-phosphor/raspberrypi/recipes-kernel/linux/linux-raspberrypi/phosphor-gpio-keys.cfg", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "78961af7a2d087971d17c41e67c6a461743f4698", "old_mode": 33188, "old_path": "meta-phosphor/raspberrypi/recipes-kernel/linux/linux-raspberrypi/phosphor-gpio-keys.scc", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "71e208cd4a67bcd6e9409f01e048ebe94562b5f8", "old_mode": 33188, "old_path": "meta-phosphor/raspberrypi/recipes-kernel/linux/linux-raspberrypi_%.bbappend", "new_id": "72d991c7e590bcac43dd2ab6da2de898cd36f829", "new_mode": 33188, "new_path": "meta-phosphor/raspberrypi/recipes-kernel/linux/linux-raspberrypi_%.bbappend" } ] }