Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openbmc / bbbc7fa29444e31201701f4f08c53cff265073ea
commitbbbc7fa29444e31201701f4f08c53cff265073ea[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Thu Aug 02 14:49:57 2018 -0500
committerBrad Bishop <bradleyb@fuzziesquirrel.com>Tue Aug 21 19:19:16 2018 +0000
tree9394d677d168b88d235b2ce13b4e97a5623888dc
parentbb3592fc96940a50a9bd8c617a8f5209420a531b [diff]
obmc-flash-bios: Remove UBI vols by id instead of name

If the name of the volume is passed to ubirmvol to be removed,
ubirmvol searches and stores the information for the available
UBI volumes, such as id, type, name, etc. If a volume is
deleted by another process while this search is in process,
ubirmvol would fail, which is the case when removing a PNOR
version since 2 separate systemd service files remove the
read-only and read-write volumes.

Instead pass ubirmvol the volume id instead of the name, so
that the ubirmvol doesn't need to do any searches and instead
knows which volume to delete.

Closes openbmc/openbmc#2863

Tested:
Verified a Delete operation does not fail with a
ubirmvol error leaving the rw volume behind. Ex:
Aug 01 16:43:03 witherspoon systemd[1]: Starting Remove UBIFS volume pnor-rw-5ac20d5d...
Aug 01 16:43:04 witherspoon systemd[1]: Starting Remove UBIFS volume pnor-ro-5ac20d5d...
Aug 01 16:43:05 witherspoon obmc-flash-bios[1458]: libubi: error!: cannot read "/sys/class/ubi/ubi8_0/type"
Aug 01 16:43:05 witherspoon obmc-flash-bios[1458]:         error 19 (No such device)
Aug 01 16:43:05 witherspoon obmc-flash-bios[1458]: ubirmvol: error!: cannot find UBI volume "pnor-rw-5ac20d5d"
Aug 01 16:43:05 witherspoon obmc-flash-bios[1458]:           error 19 (No such device)

Change-Id: Ib9aaeef4bfc268f3dac29288a469256bc771e195
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
1 file changed
tree: 9394d677d168b88d235b2ce13b4e97a5623888dc
  1. import-layers/
  2. meta-openbmc-bsp/
  3. meta-openbmc-machines/
  4. meta-phosphor/
  5. bitbake ⇨ import-layers/yocto-poky/bitbake
  6. documentation ⇨ import-layers/yocto-poky/documentation
  7. LICENSE ⇨ import-layers/yocto-poky/LICENSE
  8. meta ⇨ import-layers/yocto-poky/meta
  9. meta-poky ⇨ import-layers/yocto-poky/meta-poky
  10. meta-selftest ⇨ import-layers/yocto-poky/meta-selftest
  11. meta-skeleton ⇨ import-layers/yocto-poky/meta-skeleton
  12. meta-yocto-bsp ⇨ import-layers/yocto-poky/meta-yocto-bsp
  13. oe-init-build-env ⇨ import-layers/yocto-poky/oe-init-build-env
  14. scripts ⇨ import-layers/yocto-poky/scripts
  15. .gitignore
  16. .gitreview
  17. .templateconf
  18. MAINTAINERS
  19. openbmc-env
  20. README.md
  21. setup
README.md

OpenBMC

Build Status

The OpenBMC project can be described as a Linux distribution for embedded devices that have a BMC; typically, but not limited to, things like servers, top of rack switches or RAID appliances. The OpenBMC stack uses technologies such as Yocto, OpenEmbedded, systemd, and D-Bus to allow easy customization for your server platform.

Setting up your OpenBMC project

1) Prerequisite

  • Ubuntu 14.04
sudo apt-get install -y git build-essential libsdl1.2-dev texinfo gawk chrpath diffstat
  • Fedora 23
sudo dnf install -y git patch diffstat texinfo chrpath SDL-devel bitbake
sudo dnf groupinstall "C Development Tools and Libraries"

2) Download the source

git clone git@github.com:openbmc/openbmc.git
cd openbmc

3) Target your hardware

Any build requires an environment variable known as TEMPLATECONF to be set to a hardware target. OpenBMC has placed all known hardware targets in a standard directory structure meta-openbmc-machines/meta-[architecture]/meta-[company]/meta-[target]. You can see all of the known targets with find meta-openbmc-machines -type d -name conf. Choose the hardware target and then move to the next step. Additional examples can be found in the OpenBMC Cheatsheet

MachineTEMPLATECONF
Palmettometa-openbmc-machines/meta-openpower/meta-ibm/meta-palmetto/conf
Zaiusmeta-openbmc-machines/meta-openpower/meta-ingrasys/meta-zaius/conf
Witherspoonmeta-openbmc-machines/meta-openpower/meta-ibm/meta-witherspoon/conf

As an example target Palmetto

export TEMPLATECONF=meta-openbmc-machines/meta-openpower/meta-ibm/meta-palmetto/conf

4) Build

. openbmc-env
bitbake obmc-phosphor-image

Additional details can be found in the docs repository.

Build Validation and Testing

Commits submitted by members of the OpenBMC GitHub community are compiled and tested via our Jenkins server. Commits are run through two levels of testing. At the repository level the makefile make check directive is run. At the system level, the commit is built into a firmware image and run with an arm-softmmu QEMU model against a barrage of CI tests.

Commits submitted by non-members do not automatically proceed through CI testing. After visual inspection of the commit, a CI run can be manually performed by the reviewer.

Automated testing against the QEMU model along with supported systems are performed. The OpenBMC project uses the Robot Framework for all automation. Our complete test repository can be found here.

Submitting Patches

Support of additional hardware and software packages is always welcome. Please follow the contributing guidelines when making a submission. It is expected that contributions contain test cases.

Bug Reporting

Issues are managed on GitHub. It is recommended you search through the issues before opening a new one.

Features of OpenBMC

Feature List

  • REST Management
  • IPMI
  • SSH based SOL
  • Power and Cooling Management
  • Event Logs
  • Zeroconf discoverable
  • Sensors
  • Inventory
  • LED Management
  • Host Watchdog
  • Simulation
  • Code Update Support for multiple BMC/BIOS images
  • POWER On Chip Controller (OCC) Support

Features In Progress

  • Full IPMI 2.0 Compliance with DCMI
  • Verified Boot
  • HTML5 Java Script Web User Interface
  • BMC RAS

Features Requested but need help

  • OpenCompute Redfish Compliance
  • OpenBMC performance monitoring
  • cgroup user management and policies
  • Remote KVM
  • Remote USB
  • OpenStack Ironic Integration
  • QEMU enhancements

Finding out more

Dive deeper in to OpenBMC by opening the docs repository.

Contact