blob: ab7b65941485a5ad61d219c3085debffc3574524 [file] [log] [blame]
Brad Bishop6e60e8b2018-02-01 10:27:11 -05001From 2d2361f24be1e51201063dbbda570debe8702b6f Mon Sep 17 00:00:00 2001
Patrick Williamsc0f7c042017-02-23 20:41:17 -06002From: Jussi Kukkonen <jussi.kukkonen@intel.com>
3Date: Fri, 16 Oct 2015 16:35:16 +0300
4Subject: [PATCH 2/4] Do not try to initialize GL without libGL
5
6_gdk_x11_screen_update_visuals_for_gl() will end up calling epoxys
7GLX api which will exit() if libGL.so.1 is not present. We do not
8want that to happen and we don't want every app to have to set
9"GDK_GL=disabled" environment variable: so use #ifdef set based on
10opengl distro feature.
11
12Upstream is not interested in the fix as it is: Either epoxy should be
13fixed (to not exit) or GTK+ possibly could do some additional probing
14before calling epoxy APIs.
15
16Upstream-Status: Denied
17Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
18---
19 configure.ac | 7 +++++++
20 gdk/x11/gdkvisual-x11.c | 5 +++++
21 2 files changed, 12 insertions(+)
22
23diff --git a/configure.ac b/configure.ac
Brad Bishop6e60e8b2018-02-01 10:27:11 -050024index f43ac09..965eec9 100644
Patrick Williamsc0f7c042017-02-23 20:41:17 -060025--- a/configure.ac
26+++ b/configure.ac
Brad Bishop6e60e8b2018-02-01 10:27:11 -050027@@ -346,6 +346,13 @@ AC_ARG_ENABLE(mir-backend,
Patrick Williamsc0f7c042017-02-23 20:41:17 -060028 [enable the Mir gdk backend])],
29 [backend_set=yes])
30
31+AC_ARG_ENABLE(glx,
32+ [AS_HELP_STRING([--enable-glx],
33+ [When enabled Gdk will try to initialize GLX])])
34+AS_IF([test "x$enable_glx" != "xno"], [
35+ AC_DEFINE([HAVE_GLX], [], [GLX will be available at runtime])
36+])
37+
38 if test -z "$backend_set"; then
39 if test "$platform_win32" = yes; then
40 enable_win32_backend=yes
41diff --git a/gdk/x11/gdkvisual-x11.c b/gdk/x11/gdkvisual-x11.c
42index 81479d8..3c8c5c0 100644
43--- a/gdk/x11/gdkvisual-x11.c
44+++ b/gdk/x11/gdkvisual-x11.c
45@@ -306,7 +306,12 @@ _gdk_x11_screen_init_visuals (GdkScreen *screen)
46 /* If GL is available we want to pick better default/rgba visuals,
47 as we care about glx details such as alpha/depth/stencil depth,
48 stereo and double buffering */
49+ /* update_visuals_for_gl() will end up calling epoxy GLX api which
50+ will exit if libgl is not there: so only do this if we know GL
51+ is available */
52+#ifdef HAVE_GLX
53 _gdk_x11_screen_update_visuals_for_gl (screen);
54+#endif
55 }
56
57 gint
58--
Brad Bishop6e60e8b2018-02-01 10:27:11 -0500592.12.0
Patrick Williamsc0f7c042017-02-23 20:41:17 -060060