Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame] | 1 | From f7b8e2e149b06a8033e31f4242c392573fa9ab52 Mon Sep 17 00:00:00 2001 |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 2 | From: Changqing Li <changqing.li@windriver.com> |
| 3 | Date: Tue, 25 Jun 2019 14:25:08 +0800 |
| 4 | Subject: [PATCH] do not import target module while cross compile |
| 5 | |
| 6 | Some modules such as dynamic library maybe cann't be imported |
| 7 | while cross compile, we just check whether does the module exist. |
Patrick Williams | b48b7b4 | 2016-08-17 15:04:38 -0500 | [diff] [blame] | 8 | |
| 9 | Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com> |
| 10 | |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 11 | update to version 4.10.5, and switch to python3 |
| 12 | Signed-off-by: Changqing Li <changqing.li@windriver.com> |
| 13 | --- |
Patrick Williams | 520786c | 2023-06-25 16:20:36 -0500 | [diff] [blame] | 14 | Upstream-Status: Pending |
| 15 | |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 16 | buildtools/wafsamba/samba_bundled.py | 27 +++++++++++++++++++-------- |
Andrew Geissler | 6972109 | 2021-07-23 12:57:00 -0400 | [diff] [blame] | 17 | 1 file changed, 19 insertions(+), 8 deletions(-) |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 18 | |
| 19 | diff --git a/buildtools/wafsamba/samba_bundled.py b/buildtools/wafsamba/samba_bundled.py |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame] | 20 | index 7d2d855..01dcb56 100644 |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 21 | --- a/buildtools/wafsamba/samba_bundled.py |
| 22 | +++ b/buildtools/wafsamba/samba_bundled.py |
| 23 | @@ -4,6 +4,7 @@ import sys |
| 24 | from waflib import Build, Options, Logs |
| 25 | from waflib.Configure import conf |
| 26 | from wafsamba import samba_utils |
| 27 | +import importlib.util, os |
Patrick Williams | b48b7b4 | 2016-08-17 15:04:38 -0500 | [diff] [blame] | 28 | |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame] | 29 | def PRIVATE_NAME(bld, name): |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 30 | '''possibly rename a library to include a bundled extension''' |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame] | 31 | @@ -241,17 +242,27 @@ def CHECK_BUNDLED_SYSTEM_PYTHON(conf, libname, modulename, minversion='0.0.0'): |
Patrick Williams | b48b7b4 | 2016-08-17 15:04:38 -0500 | [diff] [blame] | 32 | # versions |
| 33 | minversion = minimum_library_version(conf, libname, minversion) |
| 34 | |
| 35 | - try: |
| 36 | - m = __import__(modulename) |
| 37 | - except ImportError: |
| 38 | - found = False |
| 39 | - else: |
| 40 | + # Find module in PYTHONPATH |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 41 | + spec = importlib.util._find_spec_from_path(modulename, [os.environ["PYTHONPATH"]]) |
| 42 | + if spec: |
Patrick Williams | b48b7b4 | 2016-08-17 15:04:38 -0500 | [diff] [blame] | 43 | try: |
| 44 | - version = m.__version__ |
| 45 | - except AttributeError: |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 46 | + module = importlib.util.module_from_spec(spec) |
| 47 | + spec.loader.load_module(module) |
Patrick Williams | b48b7b4 | 2016-08-17 15:04:38 -0500 | [diff] [blame] | 48 | + except ImportError: |
| 49 | found = False |
| 50 | + |
| 51 | + if conf.env.CROSS_COMPILE: |
| 52 | + # Some modules such as dynamic library maybe cann't be imported |
| 53 | + # while cross compile, we just check whether the module exist |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 54 | + Logs.warn('Cross module[%s] has been found, but can not be loaded.' % (spec.name)) |
Patrick Williams | b48b7b4 | 2016-08-17 15:04:38 -0500 | [diff] [blame] | 55 | + found = True |
| 56 | else: |
| 57 | - found = tuplize_version(version) >= tuplize_version(minversion) |
| 58 | + try: |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 59 | + version = module.__version__ |
Patrick Williams | b48b7b4 | 2016-08-17 15:04:38 -0500 | [diff] [blame] | 60 | + except AttributeError: |
| 61 | + found = False |
| 62 | + else: |
| 63 | + found = tuplize_version(version) >= tuplize_version(minversion) |
Patrick Williams | b48b7b4 | 2016-08-17 15:04:38 -0500 | [diff] [blame] | 64 | if not found and not conf.LIB_MAY_BE_BUNDLED(libname): |
| 65 | Logs.error('ERROR: Python module %s of version %s not found, and bundling disabled' % (libname, minversion)) |
| 66 | sys.exit(1) |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 67 | -- |
Andrew Geissler | 517393d | 2023-01-13 08:55:19 -0600 | [diff] [blame] | 68 | 2.25.1 |
Brad Bishop | 26bdd44 | 2019-08-16 17:08:17 -0400 | [diff] [blame] | 69 | |