Andrew Geissler | 82c905d | 2020-04-13 13:39:40 -0500 | [diff] [blame] | 1 | s390x_vec_op_t is not needed anywhere, only elements of enum are accessed |
| 2 | removing it ensures that valgrind can be built with -fno-common option |
| 3 | |
| 4 | Fixes |
| 5 | ld: ../../VEX/libvex-amd64-linux.a(libvex_amd64_linux_a-guest_s390_helpers.o):/usr/src/debug/valgrind/3.15.0-r0/build/VEX/../../valgrind-3.15.0/VEX/priv/guest_s390_defs.h:289: multiple definition of `s390x_vec_op_t'; ../../VEX/libvexmultiarch-amd64-linux.a(libvexmultiarch_amd64_linux_a-multiarch_main_main.o):/usr/src/debug/valgrind/3.15.0-r0/build/VEX/../../valgrind-3.15.0/VEX/priv/guest_s390_defs.h:289: first defined here |
| 6 | |
| 7 | Upstream-Status: Pending |
| 8 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
| 9 | --- a/VEX/priv/guest_s390_defs.h |
| 10 | +++ b/VEX/priv/guest_s390_defs.h |
| 11 | @@ -286,7 +286,7 @@ enum { |
| 12 | S390_VEC_OP_VFCHE = 18, |
| 13 | S390_VEC_OP_VFTCI = 19, |
| 14 | S390_VEC_OP_LAST = 20 // supposed to be the last element in enum |
| 15 | -} s390x_vec_op_t; |
| 16 | +}; |
| 17 | |
| 18 | /* Arguments of s390x_dirtyhelper_vec_op(...) which are packed into one |
| 19 | ULong variable. |