SBE watchdog times out callout support enhancement
Curently all the SBE timeout use case default callout is included
In the PEL. This commit is used to add the callout for SBE timeout
Without SBE FFDC use case. If SBE provides FFDC during watchdog
Timeout case , BMC need to honour the callout provided by SBE.
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I4523d35913965e9f55c7ae28eb728e8927b650e6
diff --git a/watchdog/watchdog_main.cpp b/watchdog/watchdog_main.cpp
index 4fa4887..00f7830 100644
--- a/watchdog/watchdog_main.cpp
+++ b/watchdog/watchdog_main.cpp
@@ -138,15 +138,21 @@
std::unique_ptr<FFDCFile> ffdcFilePtr;
try
{
- json jsonCalloutDataList;
- jsonCalloutDataList = json::array();
- getSBECallout(procTarget, jsonCalloutDataList);
- ffdcFilePtr = std::make_unique<FFDCFile>(jsonCalloutDataList);
- ffdc.push_back(std::make_tuple(
- sdbusplus::xyz::openbmc_project::Logging::server::Create::
- FFDCFormat::JSON,
- static_cast<uint8_t>(0xCA), static_cast<uint8_t>(0x01),
- ffdcFilePtr->getFileDescriptor()));
+ if (dumpIsRequired)
+ {
+ // Additional callout is required for SBE timeout case
+ // In this case no SBE FFDC information available and
+ // required to add default callouts.
+ json jsonCalloutDataList;
+ jsonCalloutDataList = json::array();
+ getSBECallout(procTarget, jsonCalloutDataList);
+ ffdcFilePtr = std::make_unique<FFDCFile>(jsonCalloutDataList);
+ ffdc.push_back(std::make_tuple(
+ sdbusplus::xyz::openbmc_project::Logging::server::Create::
+ FFDCFormat::JSON,
+ static_cast<uint8_t>(0xCA), static_cast<uint8_t>(0x01),
+ ffdcFilePtr->getFileDescriptor()));
+ }
}
catch (const std::exception& e)
{