Avoid guarding on TOD interfaces errors
The error could be anywhere between the two processors in the interface.
Fatally guarding the MDMT will cause system outage until service is
done. Instead, do not guard on the TOD interface errors to avoid outage.
Signed-off-by: Zane Shelley <zshelle@us.ibm.com>
Change-Id: I446917bad985e5143657398b2fbadacf6e8c4a9d
diff --git a/analyzer/plugins/p10-tod-plugins.cpp b/analyzer/plugins/p10-tod-plugins.cpp
index 563e558..8f1cc76 100644
--- a/analyzer/plugins/p10-tod-plugins.cpp
+++ b/analyzer/plugins/p10-tod-plugins.cpp
@@ -348,8 +348,9 @@
io_servData.calloutClock(callout::ClockType::TOD_CLOCK,
callout::Priority::MED, true);
- // Callout the MDMT chip (no guard).
- io_servData.calloutTarget(mdmtFault, callout::Priority::MED, true);
+ // Callout the MDMT chip (no guard to avoid fatal guard on primary
+ // processor when the error could be anywhere in between).
+ io_servData.calloutTarget(mdmtFault, callout::Priority::MED, false);
// Callout everything in between.
// TODO: This isn't necessary for now because the clock callout is
@@ -360,17 +361,20 @@
{
calloutsMade = true;
- // Callout all chips with network errors (guard).
+ // Callout all chips with network errors (no guard to avoid fatal
+ // guard on primary processor when the error could be anywhere in
+ // between).
for (const auto& chip : networkFaults)
{
- io_servData.calloutTarget(chip, callout::Priority::MED, true);
+ io_servData.calloutTarget(chip, callout::Priority::MED, false);
}
}
else if (!internalFaults.empty()) // interal path faults
{
calloutsMade = true;
- // Callout all chips with internal errors (guard).
+ // Callout all chips with internal errors (guard because error is
+ // isolated to this processor).
for (const auto& chip : internalFaults)
{
io_servData.calloutTarget(chip, callout::Priority::MED, true);
diff --git a/test/test-tod-step-check-fault.cpp b/test/test-tod-step-check-fault.cpp
index e91736d..dd57d51 100644
--- a/test/test-tod-step-check-fault.cpp
+++ b/test/test-tod-step-check-fault.cpp
@@ -81,9 +81,7 @@
},
{
"Deconfigured": false,
- "EntityPath": [],
- "GuardType": "GARD_Unrecoverable",
- "Guarded": true,
+ "Guarded": false,
"LocationCode": "/proc0",
"Priority": "M"
}
@@ -100,7 +98,7 @@
},
{
"Callout Type": "Hardware Callout",
- "Guard": true,
+ "Guard": false,
"Priority": "medium",
"Target": "/proc0"
}