commit 1c4b02ea682b62a74bc28986c574774755d6cdaf
author Ben Tyner <ben.tyner@ibm.com> Mon Nov 09 14:00:29 2020 -0600
committer ben.tyner <ben.tyner@ibm.com> Tue Nov 10 22:25:23 2020 +0000
tree 6b7f32967f032034c4fbbf6d2f0cc4e0e1e49a98
parent 1b1915eff34af43e2c6cb5dffc5addbdd705a916

Attn: Code cleanup based on local CI build output

Modified code based on recommendations from local CI build. Cleaned up
some potential null pointer dereferencing code.

Signed-off-by: Ben Tyner <ben.tyner@ibm.com>
Change-Id: I17fb40b25ce37627627c5112a6be786e2bac7c1f

attn/ti_handler.cpp

diff --git a/attn/ti_handler.cpp b/attn/ti_handler.cpp
index eee3553..6c3f26c 100644
--- a/attn/ti_handler.cpp
+++ b/attn/ti_handler.cpp
@@ -243,6 +243,10 @@
 void parseRawTiInfo(std::map<std::string, std::string>& i_map,
                     TiDataArea* i_buffer)
 {
+    if (nullptr == i_buffer)
+    {
+        return;
+    }
 
     uint32_t* tiDataArea = (uint32_t*)i_buffer;
     std::stringstream ss;
@@ -269,6 +273,11 @@
 void parsePhypOpalTiInfo(std::map<std::string, std::string>& i_map,
                          TiDataArea* i_tiDataArea)
 {
+    if (nullptr == i_tiDataArea)
+    {
+        return;
+    }
+
     std::stringstream ss;
 
     ss << std::hex << std::showbase;
@@ -317,6 +326,11 @@
 void parseHbTiInfo(std::map<std::string, std::string>& i_map,
                    TiDataArea* i_tiDataArea)
 {
+    if (nullptr == i_tiDataArea)
+    {
+        return;
+    }
+
     std::stringstream ss;
 
     ss << std::hex << std::showbase;