Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-hw-diags / 6bc43c9b896724c27317ac50a88e5ddaa2882484
commit6bc43c9b896724c27317ac50a88e5ddaa2882484[log] [tgz]
authorBen Tyner <ben.tyner@ibm.com>Thu May 27 15:08:02 2021 -0500
committerben.tyner <ben.tyner@ibm.com>Thu May 27 20:28:51 2021 +0000
tree7245d8f3ea6592e4c51ecbd682d73a78f1058227
parent5c5db65a37d953cb9393f257aab90a0a209d4861 [diff]
Attn: Fix attn handler crash when cfam read fails

When attention handler encounters an error while handling attentions it
will generate a PEL to track these errors. There was a bug in the code
causing attention handler to think it was handling a TI and try to
determine the subsystem (hostboot or phyp) which is only valid in a real
TI PEL case. The result was a stoi() on an invalid subsystem id.

Signed-off-by: Ben Tyner <ben.tyner@ibm.com>
Change-Id: Icc1cc4762a38854f14f3fe992fa645ccfed4c8f1
1 file changed
tree: 7245d8f3ea6592e4c51ecbd682d73a78f1058227
  1. analyzer/
  2. attn/
  3. subprojects/
  4. test/
  5. util/
  6. .clang-format
  7. .gitignore
  8. buildinfo.hpp.in
  9. cli.cpp
  10. cli.hpp
  11. config.h.in
  12. LICENSE
  13. listener.cpp
  14. listener.hpp
  15. main.cpp
  16. main_nl.cpp
  17. MAINTAINERS
  18. meson.build
  19. meson_options.txt
  20. README.md
README.md

Hardware Diagnostics for POWER Systems

In the event of a system fatal error reported by the internal system hardware (processor chips, memory chips, I/O chips, system memory, etc.), POWER Systems have the ability to diagnose the root cause of the failure and perform any service action needed to avoid repeated system failures.

Aditional details TBD.

Building

For a standard OpenBMC release build, you want something like:

meson -Dtests=disabled <build_dir>
ninja -C <build_dir>
ninja -C <build_dir> install

For a test / debug build, a typical configuration is:

meson -Dtests=enabled <build_dir>
ninja -C <build_dir> test