commit 7a0dd543c8fef050f7347dde760e6aff84b07122
author Ben Tyner <ben.tyner@ibm.com> Fri Feb 12 09:33:44 2021 -0600
committer Zane Shelley <zshelle@us.ibm.com> Mon Feb 22 16:50:28 2021 +0000
tree 4d914ee50a4b98f1917861ae9221515583163df6
parent 6764d70eea47a83adc98c1266dd2f7eb5b7456c8

Attn: Procedure specific error codes in error logs

When creating error logs for attention handler failures an error code is
presented in the error log. Make these specific to the attention handler
procedure that encountered the error.

Signed-off-by: Ben Tyner <ben.tyner@ibm.com>
Change-Id: Ic65343c2cc231ad6340cb5182a1fa75da7c76bcb

attn/attn_handler.cpp

diff --git a/attn/attn_handler.cpp b/attn/attn_handler.cpp
index c41e231..693e4c8 100644
--- a/attn/attn_handler.cpp
+++ b/attn/attn_handler.cpp
@@ -100,7 +100,8 @@
                 {
                     // log cfam read error
                     trace<level::INFO>("Error! cfam read 0x1007 FAILED");
-                    eventAttentionFail(RC_CFAM_ERROR);
+                    eventAttentionFail((int)AttnSection::attnHandler |
+                                       ATTN_PDBG_CFAM);
                 }
                 else if (0xffffffff == isr_val)
                 {
@@ -123,7 +124,8 @@
                     {
                         // log cfam read error
                         trace<level::INFO>("Error! cfam read 0x100d FAILED");
-                        eventAttentionFail(RC_CFAM_ERROR);
+                        eventAttentionFail((int)AttnSection::attnHandler |
+                                           ATTN_PDBG_CFAM);
                     }
                     else if (0xffffffff == isr_mask)
                     {
@@ -292,9 +294,8 @@
             // trace some more data since TI info appears valid
             ss.str(std::string()); // empty the stream
             ss.clear();            // clear the stream
-            ss << "TI data hb_terminate_type = 0x" << std::setw(2)
-               << std::setfill('0') << std::hex
-               << (int)tiDataArea->hbTerminateType;
+            ss << "TI data term-type = 0x" << std::setw(2) << std::setfill('0')
+               << std::hex << (int)tiDataArea->hbTerminateType;
             strobj = ss.str();
             trace<level::INFO>(strobj.c_str());
 
@@ -337,8 +338,6 @@
         // if configured to handle TI as default special attention
         else
         {
-            trace<level::INFO>("assuming TI");
-
             if (true == (i_attention->getConfig()->getFlag(enTerminate)))
             {
                 // Call TI special attention handler