commit 98430b3033c72ce8c293aa0b7d51a7ea8b94464b
author Ben Tyner <ben.tyner@ibm.com> Wed Aug 19 19:14:02 2020 -0500
committer Ben Tyner <ben.tyner@ibm.com> Wed Aug 19 19:14:02 2020 -0500
tree 59b8e71ca06e3078295b659abd172aba8f39127e
parent 06e10f91faad6d3bc50c81670f9e100f8269a9d6

ATTN: Get TI Info PIB target from path

Changed code to find PIB target, for get TI info chipop, to use the path
from PROC rather than iterate through targets by class.

Signed-off-by: Ben Tyner <ben.tyner@ibm.com>
Change-Id: I856d95127b6d41d543fd45357342dbbd6b4e10a7

attn/attn_handler.cpp

diff --git a/attn/attn_handler.cpp b/attn/attn_handler.cpp
index 016b33f..04447ab 100644
--- a/attn/attn_handler.cpp
+++ b/attn/attn_handler.cpp
@@ -244,18 +244,28 @@
     int rc = RC_SUCCESS; // assume special attention handled
 
     // The TI infor chipop will give us a pointer to the TI info data
-    uint8_t* tiInfo    = nullptr; // ptr to TI info data
-    uint32_t tiInfoLen = 0;       // length of TI info data
-    pdbg_target *tiInfoTarget, *attnProc;
+    uint8_t* tiInfo       = nullptr;                  // ptr to TI info data
+    uint32_t tiInfoLen    = 0;                        // length of TI info data
+    pdbg_target* attnProc = i_attention->getTarget(); // proc with attention
 
-    attnProc = i_attention->getTarget();
-
-    pdbg_for_each_target("pib", attnProc, tiInfoTarget)
+    if (attnProc != nullptr)
     {
-        if (PDBG_TARGET_ENABLED == pdbg_target_probe(tiInfoTarget))
+        // The processor PIB target is required for get TI info chipop
+        char path[16];
+        sprintf(path, "/proc%d/pib", pdbg_target_index(attnProc));
+        pdbg_target* tiInfoTarget = pdbg_target_from_path(nullptr, path);
+
+        if (nullptr != tiInfoTarget)
         {
-            sbe_mpipl_get_ti_info(tiInfoTarget, &tiInfo, &tiInfoLen);
-            break;
+            if (PDBG_TARGET_ENABLED == pdbg_target_probe(tiInfoTarget))
+            {
+                trace<level::INFO>("calling sbe_mpipl_get_ti_info");
+                sbe_mpipl_get_ti_info(tiInfoTarget, &tiInfo, &tiInfoLen);
+                if (tiInfo == nullptr)
+                {
+                    trace<level::INFO>("TI info data ptr is null after call");
+                }
+            }
         }
     }
 
@@ -266,6 +276,8 @@
     // If TI area exists and is marked valid we can assume TI occurred
     if ((nullptr != tiInfo) && (0 != tiInfo[0]))
     {
+        trace<level::INFO>("TI info data present and valid");
+
         TiDataArea* tiDataArea = (TiDataArea*)tiInfo;
 
         // trace a few known TI data area values
@@ -288,6 +300,8 @@
     // TI area not valid, assume breakpoint
     else
     {
+        trace<level::INFO>("TI info NOT available, assume breakpoint");
+
         if (true == (i_attention->getConfig()->getFlag(enBreakpoints)))
         {
             trace<level::INFO>("breakpoint");