commit d700609cb6dbae60e4698ecf62b92b906f369067
author Ben Tyner <ben.tyner@ibm.com> Fri Feb 05 14:55:52 2021 -0600
committer ben.tyner <ben.tyner@ibm.com> Wed Feb 10 04:36:05 2021 +0000
tree 9b823a4b1e5ba11c9ad18c4385553a27849db77f
parent 8882c32a2cbbfd047a5ff0424af027bd6f3ad0fd

Attn: Fix CI complaint of unused-results

Use the results provided by file read/write operations. For mismatch in
number of bytes written on ffdc data creation we add a trace message,
for mismatch in number of bytes read during pel creation we skip
creating the pel.

Signed-off-by: Ben Tyner <ben.tyner@ibm.com>
Change-Id: I3ec6755ef258ac869775b08afafae324a76a2884

attn/attn_logging.cpp

diff --git a/attn/attn_logging.cpp b/attn/attn_logging.cpp
index c4ab877..f50aba5 100644
--- a/attn/attn_logging.cpp
+++ b/attn/attn_logging.cpp
@@ -15,6 +15,12 @@
     phosphor::logging::log<phosphor::logging::level::INFO>(i_message);
 }
 
+template <>
+void trace<ERROR>(const char* i_message)
+{
+    phosphor::logging::log<phosphor::logging::level::ERR>(i_message);
+}
+
 /** @brief Tuple containing information about ffdc files */
 using FFDCTuple =
     std::tuple<util::FFDCFormat, uint8_t, uint8_t, sdbusplus::message::unix_fd>;
@@ -56,8 +62,17 @@
     util::FFDCFile file{util::FFDCFormat::Custom};
 
     // Write buffer to file and then reset file description file offset
-    int fd = file.getFileDescriptor();
-    write(fd, static_cast<char*>(i_buffer), i_size);
+    int fd          = file.getFileDescriptor();
+    size_t numBytes = write(fd, static_cast<char*>(i_buffer), i_size);
+    if (i_size != numBytes)
+    {
+        std::stringstream traceMsg;
+        traceMsg << file.getPath().c_str() << " only " << (int)numBytes
+                 << " of " << (int)i_size << " bytes written";
+        auto strobj = traceMsg.str();
+        trace<level::ERROR>(strobj.c_str());
+    }
+
     lseek(fd, 0, SEEK_SET);
 
     return file;
@@ -89,7 +104,15 @@
         }
 
         // write buffer to file
-        write(fd, buffer.c_str(), buffer.size());
+        size_t numBytes = write(fd, buffer.c_str(), buffer.size());
+        if (buffer.size() != numBytes)
+        {
+            std::stringstream traceMsg;
+            traceMsg << file.getPath().c_str() << " only " << (int)numBytes
+                     << " of " << (int)buffer.size() << " bytes written";
+            auto strobj = traceMsg.str();
+            trace<level::ERROR>(strobj.c_str());
+        }
     }
 
     // Seek to beginning of file so error logging system can read data
@@ -319,11 +342,22 @@
 
                 // read information PEL into buffer
                 std::vector<uint8_t> buffer(pelSize);
-                read(pelFd, buffer.data(), buffer.size());
-                close(pelFd);
+                size_t numBytes = read(pelFd, buffer.data(), buffer.size());
+                if (buffer.size() != numBytes)
+                {
+                    std::stringstream traceMsg;
+                    traceMsg << "Error reading event log: " << (int)numBytes
+                             << " of " << (int)buffer.size() << " bytes read";
+                    auto strobj = traceMsg.str();
+                    trace<level::ERROR>(strobj.c_str());
+                }
+                else
+                {
+                    // create PEL from buffer
+                    createPelCustom(buffer, i_additional);
+                }
 
-                // create PEL from buffer
-                createPelCustom(buffer, i_additional);
+                close(pelFd);
             }
         }
     }