Update to HardwareRegister BitString access
Change-Id: Id8050ad8ef9f8edc2da206106ac98d6d7763ad23
Signed-off-by: Zane Shelley <zshelle@us.ibm.com>
diff --git a/src/register/hei_hardware_register.cpp b/src/register/hei_hardware_register.cpp
index d3c5dd0..3334662 100755
--- a/src/register/hei_hardware_register.cpp
+++ b/src/register/hei_hardware_register.cpp
@@ -44,7 +44,6 @@
//------------------------------------------------------------------------------
-#if 0
BitString & HardwareRegister::accessBitString( const Chip & i_chip )
{
// Verify this register belongs on i_chip.
@@ -64,7 +63,6 @@
return accessCache( i_chip );
}
-#endif
//------------------------------------------------------------------------------
diff --git a/src/register/hei_hardware_register.hpp b/src/register/hei_hardware_register.hpp
index ce7c6a9..a0ce387 100755
--- a/src/register/hei_hardware_register.hpp
+++ b/src/register/hei_hardware_register.hpp
@@ -102,7 +102,7 @@
public:
/** Function overloaded from parent Register class. */
- virtual const BitString * getBitString( const Chip & i_chip ) const;
+ const BitString * getBitString( const Chip & i_chip ) const;
#if 0
/**
@@ -137,16 +137,18 @@
#endif // __HEI_READ_ONLY
-#if 0
- protected: // Functions
+ protected:
/**
+ * @brief Provides access to this register's BitString.
+ *
+ * WARNING: Allowing public access to this function may be dangerous. For
+ * now it should be left as protected.
+ *
* @param i_chip The target chip in which this register belongs.
- * @return If iv_operationType indicates a register read is possible
- * (ACCESS_RO or ACCESS_RW), returns a reference to bit string.
+ * @return A reference to the BitString.
*/
- virtual BitString & accessBitString( const Chip & i_chip );
-#endif
+ BitString & accessBitString( const Chip & i_chip );
private: // Hardware accessor management functions.