Add register dump to isolation data
Signed-off-by: Zane Shelley <zshelle@us.ibm.com>
Change-Id: I02dc9ff21e538a8d6d66663bc0ecd07362a5332b
diff --git a/src/isolator/hei_isolation_node.cpp b/src/isolator/hei_isolation_node.cpp
index 15bf5cf..51e3ee0 100644
--- a/src/isolator/hei_isolation_node.cpp
+++ b/src/isolator/hei_isolation_node.cpp
@@ -20,6 +20,7 @@
// Read the register (adds BitString to register cache).
if (hwReg->read(i_chip))
{
+ // The register read failed.
// TODO: Would be nice to add SCOM errors to the log just in case
// traces are not available.
// TODO: This trace could be redundant with the user application,
@@ -30,13 +31,12 @@
// "address=0x%0" PRIx64,
// i_chip.getType(), hwReg->getAddress());
}
-
- // TODO: Add this register to io_isoData.
- // TODO: getBitString() does read hardware if read() has not been called
- // and there is nothing in the register cache. However, it does
- // not does not indicate if the read was successful. Not sure if
- // this is intentional. Will need to investigate.
- // auto bs = hwReg->getBitString();
+ else
+ {
+ // Add to the FFDC.
+ io_isoData.addRegister(i_chip, hwReg->getId(), hwReg->getInstance(),
+ hwReg->getBitString(i_chip));
+ }
}
// A rule for i_attnType must exist.