commit 358d3966d3381c7e404a546dbf0e9a33473ef398
author Chris Cain <cjcain@us.ibm.com> Fri Aug 23 15:29:38 2024 -0500
committer Chris Cain <cjcain@us.ibm.com> Mon Aug 26 09:28:34 2024 -0500
tree 4b8858ca6f99a909dc80e8726268789f068509d3
parent d7542c83b1acd145e0bbf2c1b6307911dfcebf7a

Fix OCC response checksum calculation

The OCC checksum calculation should be ignoring overflow.

Removed redundant trace of the occActive state:
'''
Aug 23 18:38:52 rain100bmc openpower-occ-control[6515]: updateOCCActive: OCC0 active=true
Aug 23 18:38:52 rain100bmc openpower-occ-control[6515]: Status::occActive OCC0 changed to true
'''

Added trace of first 4 bytes of data for pass-through commands:
'''
Aug 23 19:19:30 rain100bmc openpower-occ-control[27848]: PassThrough::send() Sending 0x00 command to OCC0 (data len=1, data=0x20)
Aug 23 19:19:40 rain100bmc openpower-occ-control[27848]: PassThrough::send() Sending 0x40 command to OCC0 (data len=5, data=0x07001000...)
'''

Change-Id: I632b0e0af214858e15f3d5c196723dc6ffe12445
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

occ_manager.cpp

diff --git a/occ_manager.cpp b/occ_manager.cpp
index 932b052..ada95ef 100644
--- a/occ_manager.cpp
+++ b/occ_manager.cpp
@@ -560,9 +560,6 @@
         }
         else
         {
-            log<level::INFO>(std::format("updateOCCActive: OCC{} active={}",
-                                         instance, status)
-                                 .c_str());
             (*obj)->setPldmSensorReceived(true);
             return (*obj)->occActive(status);
         }
@@ -731,7 +728,8 @@
     }
     catch (const openpower::phal::exception::SbeError& e)
     {
-        log<level::ERR>("Failed to set SBE state");
+        log<level::ERR>(
+            std::format("Failed to set SBE state: {}", e.what()).c_str());
     }
 }