Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-pnor-code-mgmt / 1cb127fbc5c34ec8f1e61c8800985db36f50ae8b
commit1cb127fbc5c34ec8f1e61c8800985db36f50ae8b[log] [tgz]
authorMichael Tritz <mtritz@us.ibm.com>Wed Jul 26 15:40:38 2017 -0500
committerPatrick Williams <patrick@stwcx.xyz>Wed Aug 02 10:45:03 2017 +0000
tree8897b0866b123a53bcbf5dc481e2dd9a77ff7096
parent60bc20fe36517be7c7ae4f2aac976ed3dd6acdc2 [diff]
PNOR Activation: Minor code-review fixes

This commit follows openbmc/openbmc#1716, addressing a pair of minor
issues raised in the code review process for that issue.

In order to shorten and clarify the function Activation::activation(),
much of the content is moved to a pair of private member functions. A
few other miscellaneous cosmetic changes are made for similar reasons.

Additionally, a function is added to unsubscribe activation objects from
dbus signals after the completion of the activation process.

Resolves openbmc/openbmc#1843

Change-Id: I815e3d70850aac1f870aa741b6415a7714696367
Signed-off-by: Michael Tritz <mtritz@us.ibm.com>
2 files changed
tree: 8897b0866b123a53bcbf5dc481e2dd9a77ff7096
  1. m4/
  2. test/
  3. .gitignore
  4. activation.cpp
  5. activation.hpp
  6. bootstrap.sh
  7. configure.ac
  8. generate-squashfs
  9. item_updater.cpp
  10. item_updater.hpp
  11. item_updater_main.cpp
  12. LICENSE
  13. Makefile.am
  14. README.md
  15. serialize.cpp
  16. serialize.hpp
  17. version.cpp
  18. version.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To full clean the repository again run `./bootstrap.sh clean`.