Refactor: Fix issues found by cppcheck
Resolve several issues found by cppcheck:
[msl_verify.hpp:28]: (style) Class 'MinimumShipLevel' has a constructor with 1 argument that is not explicit.
[ubi/watch.hpp:21]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
[item_updater_main.cpp:22] -> [item_updater_main.cpp:49]: (style) Local variable rc shadows outer symbol
[serialize.cpp:19]: (performance) Function parameter 'versionId' should be passed by const reference.
[ubi/watch.hpp:43]: (style) Struct 'CustomFd' has a constructor with 1 argument that is not explicit.
[serialize.cpp:52]: (performance) Function parameter 'versionId' should be passed by const reference.
[serialize.cpp:116]: (performance) Function parameter 'versionId' should be passed by const reference.
[activation.cpp:115] -> [activation.cpp:152]: (style) Local variable mapperResponseMsg shadows outer symbol
[version.hpp:114]: (performance) Variable 'eraseCallback' is assigned in constructor body. Consider performing initialization in initialization list.
[image_verify.hpp:53]: (style) Struct 'CustomFd' has a constructor with 1 argument that is not explicit.
[ubi/item_updater_ubi.cpp:192]: (performance) Function parameter 'versionId' should be passed by const reference.
[ubi/item_updater_ubi.cpp:203]: (performance) Function parameter 'versionId' should be passed by const reference.
Tested: Verify the code compiles and cppcheck does not report the above
issues.
Change-Id: I096392a2a7a283fe198c9c29185125e61295e10f
Signed-off-by: Lei YU <mine260309@gmail.com>
diff --git a/version.hpp b/version.hpp
index 831b201..13f772f 100644
--- a/version.hpp
+++ b/version.hpp
@@ -99,8 +99,8 @@
const std::string& versionString, VersionPurpose versionPurpose,
const std::string& filePath, eraseFunc callback) :
VersionInherit(bus, (objPath).c_str(), true),
- bus(bus), objPath(objPath), parent(parent), versionId(versionId),
- versionStr(versionString),
+ eraseCallback(callback), bus(bus), objPath(objPath), parent(parent),
+ versionId(versionId), versionStr(versionString),
chassisStateSignals(
bus,
sdbusRule::type::signal() + sdbusRule::member("PropertiesChanged") +
@@ -110,8 +110,6 @@
std::bind(std::mem_fn(&Version::updateDeleteInterface), this,
std::placeholders::_1))
{
- // Bind erase method
- eraseCallback = callback;
// Set properties.
purpose(versionPurpose);
version(versionString);