Guard: Guarded DIMMS/CPU are not enabled back after factory reset
User not able to enable some of the guarded dimm/cpu after host
factory reset even though host cleared the guards in the guard
partition.
BMC will not know that host took a factory reset for it to clear the
disabled flag for the earlier guarded dimm/cpu.
Modified to force enable all the cpu/dimm during host factory reset.
Test result:
openpower-update-manager[2001]:ItemUpdaterMMC::reset
openpower-update-manager[2001]:GardResetMMC::reset
openpower-update-manager[2001]:GardResetMMC::enableInventoryItems
openpower-update-manager[2001]:GardResetMMC::enableInventoryItemsHelper
openpower-update-manager[2001]:enable specified inventory items
OBJ(/xyz/openbmc_project/inventory/system/chassis/motherboard/dcm0/cpu0/core13)
openpower-update-manager[2001]:enable specified inventory items
OBJ(/xyz/openbmc_project/inventory/system/chassis/motherboard/dcm0/cpu0/core14)
openpower-update-manager[2001]:GardResetMMC::enableInventoryItemsHelper
openpower-update-manager[2001]:enable specified inventory items
OBJ(/xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0)
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>`
Change-Id: I7f7d3981d38cdc6cc7dda4e3ee49403c772dc5ef
diff --git a/item_updater.hpp b/item_updater.hpp
index 0b880c7..c8b414d 100644
--- a/item_updater.hpp
+++ b/item_updater.hpp
@@ -56,16 +56,16 @@
virtual ~GardReset()
{}
+ /**
+ * @brief GARD factory reset - clears the PNOR GARD partition.
+ */
+ virtual void reset() = 0;
+
protected:
// TODO Remove once openbmc/openbmc#1975 is resolved
static constexpr auto interface = "xyz.openbmc_project.Common.FactoryReset";
sdbusplus::bus_t& bus;
std::string path;
-
- /**
- * @brief GARD factory reset - clears the PNOR GARD partition.
- */
- virtual void reset() = 0;
};
/** @class ItemUpdater