Fix up InternalFailure to include metadata
Scope is to add missing logs for InternalFailure errors
Change-Id: I91dce3221b54b55fd562d2ed730614c489eecb55
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
diff --git a/item_updater.cpp b/item_updater.cpp
index adc6f7c..6b9ec1c 100644
--- a/item_updater.cpp
+++ b/item_updater.cpp
@@ -333,22 +333,28 @@
if (reply.is_method_error())
{
+ log<level::ERR>("Failed to clear read-write partitions",
+ entry("SERVICE_FILE=%s", serviceFile));
elog<InternalFailure>();
}
removeFile(it.first);
}
+ static constexpr auto serviceFile =
+ "obmc-flash-bios-ubiclear@pnor-prsv.service";
// Clear the preserved partition.
auto method = bus.new_method_call(
SYSTEMD_BUSNAME,
SYSTEMD_PATH,
SYSTEMD_INTERFACE,
"StartUnit");
- method.append("obmc-flash-bios-ubiclear@pnor-prsv.service", "replace");
+ method.append(serviceFile, "replace");
auto reply = bus.call(method);
if (reply.is_method_error())
{
+ log<level::ERR>("Failed to clear preserved partition",
+ entry("SERVICE_FILE=%s", serviceFile));
elog<InternalFailure>();
}