Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-pnor-code-mgmt / 1db9adf37900c8503b3c9fa3fe39eef9406a30ff
commit1db9adf37900c8503b3c9fa3fe39eef9406a30ff[log] [tgz]
authorLei YU <mine260309@gmail.com>Tue Mar 05 16:02:31 2019 +0800
committerLei YU <mine260309@gmail.com>Wed Mar 13 11:01:53 2019 +0800
tree7bc71b34d81babad764997c3c7620b88c9a2da31
parent07830764398601b38d6dea9db269a7fb8efabbc8 [diff]
Refactor: Fix issues found by cppcheck

Resolve several issues found by cppcheck:

    [msl_verify.hpp:28]: (style) Class 'MinimumShipLevel' has a constructor with 1 argument that is not explicit.
    [ubi/watch.hpp:21]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
    [item_updater_main.cpp:22] -> [item_updater_main.cpp:49]: (style) Local variable rc shadows outer symbol
    [serialize.cpp:19]: (performance) Function parameter 'versionId' should be passed by const reference.
    [ubi/watch.hpp:43]: (style) Struct 'CustomFd' has a constructor with 1 argument that is not explicit.
    [serialize.cpp:52]: (performance) Function parameter 'versionId' should be passed by const reference.
    [serialize.cpp:116]: (performance) Function parameter 'versionId' should be passed by const reference.
    [activation.cpp:115] -> [activation.cpp:152]: (style) Local variable mapperResponseMsg shadows outer symbol
    [version.hpp:114]: (performance) Variable 'eraseCallback' is assigned in constructor body. Consider performing initialization in initialization list.
    [image_verify.hpp:53]: (style) Struct 'CustomFd' has a constructor with 1 argument that is not explicit.
    [ubi/item_updater_ubi.cpp:192]: (performance) Function parameter 'versionId' should be passed by const reference.
    [ubi/item_updater_ubi.cpp:203]: (performance) Function parameter 'versionId' should be passed by const reference.

Tested: Verify the code compiles and cppcheck does not report the above
        issues.

Change-Id: I096392a2a7a283fe198c9c29185125e61295e10f
Signed-off-by: Lei YU <mine260309@gmail.com>
10 files changed
tree: 7bc71b34d81babad764997c3c7620b88c9a2da31
  1. m4/
  2. org/
  3. static/
  4. test/
  5. ubi/
  6. .clang-format
  7. .gitignore
  8. activation.cpp
  9. activation.hpp
  10. bootstrap.sh
  11. configure.ac
  12. generate-tar
  13. generate-ubi
  14. image_verify.cpp
  15. image_verify.hpp
  16. item_updater.cpp
  17. item_updater.hpp
  18. item_updater_main.cpp
  19. LICENSE
  20. MAINTAINERS
  21. Makefile.am
  22. msl_verify.cpp
  23. msl_verify.hpp
  24. msl_verify_main.cpp
  25. openpower-pnor-update@.service
  26. README.md
  27. utils.cpp
  28. utils.hpp
  29. version.cpp
  30. version.hpp
README.md

openpower-pnor-code-mgmt

OpenPower PNOR (Processor NOR) Code Management provides a set of host software management applications for OpenPower systems. The host firmware is stored on the PNOR chip. More information can be found at Software Architecture or Host Code Update

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.