commit 91add6df04d65b4cddf9458e1c223163f9ad5764
author Lei YU <mine260309@gmail.com> Fri Mar 01 14:23:40 2019 +0800
committer Lei YU <mine260309@gmail.com> Wed Mar 13 11:01:53 2019 +0800
tree 2d0efea118e88aad809e4df790df6d47be7b6148
parent 6da3dae3b40bdbe9663b94e1f36dd3e2833d9c14

Static layout: Do not crash on empty PNOR

When PNOR is empty, or corrupted and it fails to retrieve the version,
the service throws an exception.
This is not good because it should run on a corrupted or empty PNOR,
which then could be used to re-program the PNOR.

This commit fixes the issue, by not throwing on the above case.

Tested: Verify the service does not crash on a corrupted VERSION
        partition, and could be used to do code update to fix the
        corruption.

Change-Id: Ic6a413a81ad13894a9c7f039df71fff9b9d4b2ad
Signed-off-by: Lei YU <mine260309@gmail.com>

version.cpp

diff --git a/version.cpp b/version.cpp
index d9ad395..c6e43fc 100644
--- a/version.cpp
+++ b/version.cpp
@@ -30,8 +30,7 @@
     if (version.empty())
     {
         log<level::ERR>("Error version is empty");
-        elog<InvalidArgument>(Argument::ARGUMENT_NAME("Version"),
-                              Argument::ARGUMENT_VALUE(version.c_str()));
+        return {};
     }
 
     unsigned char digest[SHA512_DIGEST_LENGTH];