commit be20e8722ed86bf929995e96a2d2c99a85b1b51a
author Andrew Geissler <geissonator@yahoo.com> Tue Mar 30 19:20:53 2021 -0500
committer Adriana Kobylak <anoo@linux.ibm.com> Fri Apr 30 14:41:33 2021 +0000
tree b024a66d5544f5d6e5da5f4eaeb5792e89273045
parent a7b1f4caa49390064d0b66de04764547f3aa41c9

ensure hostboot volatile not cleared on warm reboots

A while back, the obmc-vpnor-enable-clearvolatile@.service was added to
the obmc-chassis-poweron@.target. This was done to ensure the volatile
data was cleared on any chassis power on to handle situations where the
user is using debug tools like istep or cronus to boot the system after
the chassis power was turned on. Prior to that, the clear was done only
when obmc-host-start@.target was started.

Adding this service to the obmc-chassis-poweron@target had an unintended
consequence though. The chassis power on target is called during a warm
reboot. The assumption was that all services were already running so it
was a "warm" reboot because none of those service were re-run. The
obmc-vpnor-enable-clearvolatile@.service however is a onetime service
that did not remain after exit. This means this service was run during
this warm reboot which breaks the design point of not clearing the host
volatile data on a warm reboot.

This commit now makes this service continue after it has run and only
stops it when a chassis power off is issued. This ensures the host
volatile data is only ever cleared after a system has its chassis
powered off.

Tested:
- Verified that a warm reboot now results in the service not running
- Verified that a normal host reboot (chassis power cycle) still results
  in the service running as expected

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ifad75b4d0f7a4e1162d4a45a1c346e622a458240