Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-pnor-code-mgmt / 01f71428f2cd0def4cf76240bd2565b7e58187e8
commit01f71428f2cd0def4cf76240bd2565b7e58187e8[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Fri Feb 07 09:58:50 2025 -0600
committerAdriana Kobylak <anoo@us.ibm.com>Fri Feb 07 10:06:16 2025 -0600
tree7253014d6f2e91b7374c75ddab6da6708b65ac52
parent837b09428d86a80fcae589b81c2fc7b00dd36484 [diff]
mmc: clang-tidy: Add override keyword

Marked virtual functions with the `override` keyword to ensure
they correctly override base class functions. This resolves
-Winconsistent-missing-override warnings and improves code safety
and readability by explicitly indicating overridden functions.

```
Error while processing /var/jenkins-openbmc/workspace/ci-repository/openbmc/openpower-pnor-code-mgmt/mmc/item_updater_mmc.hpp.
/var/jenkins-openbmc/workspace/ci-repository/openbmc/openpower-pnor-code-mgmt/mmc/item_updater_mmc.hpp:94:10: error: 'validateImage' overrides a member function but is not marked 'override' [clang-diagnostic-inconsistent-missing-override]
   94 |     bool validateImage(const std::string& path);
      |          ^
../item_updater.hpp:199:18: note: overridden virtual function is here
  199 |     virtual bool validateImage(const std::string& path) = 0;
      |                  ^
```

Tested: CI runs with no errors.

Change-Id: I24e5cae09e2cdeacf0155d5de70a6ecbae5e00e0
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
1 file changed
tree: 7253014d6f2e91b7374c75ddab6da6708b65ac52
  1. dbus/
  2. mmc/
  3. static/
  4. test/
  5. ubi/
  6. vpnor/
  7. .clang-format
  8. .clang-tidy
  9. .gitignore
  10. .shellcheck
  11. activation.cpp
  12. activation.hpp
  13. functions.cpp
  14. functions.hpp
  15. generate-tar
  16. generate-ubi
  17. image_verify.cpp
  18. image_verify.hpp
  19. item_updater.cpp
  20. item_updater.hpp
  21. item_updater_main.cpp
  22. LICENSE
  23. meson.build
  24. meson.options
  25. msl_verify.cpp
  26. msl_verify.hpp
  27. msl_verify_main.cpp
  28. op-pnor-msl.service
  29. openpower-pnor-update@.service
  30. org.open_power.Software.Host.Updater.service
  31. OWNERS
  32. README.md
  33. utils.cpp
  34. utils.hpp
  35. version.cpp
  36. version.hpp
README.md

openpower-pnor-code-mgmt

OpenPower PNOR (Processor NOR) Code Management provides a set of host software management applications for OpenPower systems. The host firmware is stored on the PNOR chip. More information can be found at Software Architecture or Host Code Update

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.