commit e4290949c29632231b0067dda3429e43b7439ead
author Patrick Williams <patrick@stwcx.xyz> Fri Jun 16 05:43:08 2017 -0500
committer Patrick Williams <patrick@stwcx.xyz> Fri Jun 16 05:43:08 2017 -0500
tree ed3cc10b9c90be70f771062246569d7fe609e858
parent ce1487002514aa643e102c4292e05fa1b670ae53

item_updater: style simplification

Change-Id: I71c37c1ea0324ffab639852b725d3a853adbc3dc
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

item_updater.cpp

diff --git a/item_updater.cpp b/item_updater.cpp
index 41e4196..2caacfe 100755
--- a/item_updater.cpp
+++ b/item_updater.cpp
@@ -24,14 +24,19 @@
 
 void ItemUpdater::createActivation(sdbusplus::message::message& m)
 {
+    using SVersion = server::Version;
+    using VersionPurpose = SVersion::VersionPurpose;
+    namespace msg = sdbusplus::message;
+    namespace variant_ns = msg::variant_ns;
+
     sdbusplus::message::object_path objPath;
     std::map<std::string,
-             std::map<std::string,
-                      sdbusplus::message::variant<std::string>>> interfaces;
+             std::map<std::string, msg::variant<std::string>>> interfaces;
     m.read(objPath, interfaces);
+
     std::string path(std::move(objPath));
     std::string filePath;
-    auto purpose = server::Version::VersionPurpose::Unknown;
+    auto purpose = VersionPurpose::Unknown;
     std::string version;
 
     for (const auto& intf : interfaces)
@@ -43,20 +48,18 @@
                 if (property.first == "Purpose")
                 {
                     // Only process the Host and System images
-                    std::string str = sdbusplus::message::variant_ns::get<
-                        std::string>(property.second);
-                    auto value = server::Version::
-                        convertVersionPurposeFromString(str);
-                    if (value == server::Version::VersionPurpose::Host ||
-                        value == server::Version::VersionPurpose::System)
+                    auto value = SVersion::convertVersionPurposeFromString(
+                            variant_ns::get<std::string>(property.second));
+
+                    if (value == VersionPurpose::Host ||
+                        value == VersionPurpose::System)
                     {
                         purpose = value;
                     }
                 }
                 else if (property.first == "Version")
                 {
-                    version = sdbusplus::message::variant_ns::
-                        get<std::string>(property.second);
+                    version = variant_ns::get<std::string>(property.second);
                 }
             }
         }
@@ -66,14 +69,12 @@
             {
                 if (property.first == "Path")
                 {
-                    filePath = sdbusplus::message::variant_ns::get<
-                            std::string>(property.second);
+                    filePath = variant_ns::get<std::string>(property.second);
                 }
             }
         }
     }
-    if ((filePath.empty()) || (purpose == server::Version::
-            VersionPurpose::Unknown))
+    if ((filePath.empty()) || (purpose == VersionPurpose::Unknown))
     {
         return;
     }