Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-pnor-code-mgmt / 4c2386a575c9bd2f69d73af131cd635cc3c09b04
commit4c2386a575c9bd2f69d73af131cd635cc3c09b04[log] [tgz]
authorAdriana Kobylak <anoo@us.ibm.com>Fri Sep 17 14:12:26 2021 +0000
committerAdriana Kobylak <anoo@linux.ibm.com>Fri Sep 17 14:36:16 2021 +0000
tree37edeecd0985c6d868f2ba7f2a38e9d64cd59904
parentff675db0cea05b3a829aa5a125d95d1392105e94 [diff]
mmc: Add dependency to openpower-update-bios-attr-table.service

The openpower-update-bios-attr-table.service creates symlinks to lid
files is the partition files do not exist. The service
openpower-process-host-firmware.service creates symlinks to the well
known firmware name by deleting the base partition file and creting a
symlink. If both services run at the same time, they can interfere,
causing the bios attr service to create a symlink when it's not desired
(it thinks the file doesn't exist but it's because the process host fw
service just deleted it to create its symlink). Add a dependency to
serialize them.

Tested:
Before fix:
Sep 17 14:18:35 p10bmc systemd[1]: Starting Set POWER host firmware well-known names...
Sep 17 14:18:35 p10bmc systemd[1]: Starting Update BIOS attr table with host firmware well-known names...
Sep 17 14:18:35 p10bmc openpower-update-manager[2026]: "/media/hostfw/running/DEVTREE": File exists
Sep 17 14:18:35 p10bmc systemd[1]: openpower-process-host-firmware.service: Deactivated successfully.
Sep 17 14:18:35 p10bmc systemd[1]: Finished Set POWER host firmware well-known names.
Sep 17 14:18:35 p10bmc systemd[1]: openpower-update-bios-attr-table.service: Deactivated successfully.
Sep 17 14:18:35 p10bmc systemd[1]: Finished Update BIOS attr table with host firmware well-known names.

After fix:
Sep 17 14:19:26 p10bmc systemd[1]: Starting Set POWER host firmware well-known names...
Sep 17 14:19:26 p10bmc systemd[1]: openpower-process-host-firmware.service: Deactivated successfully.
Sep 17 14:19:26 p10bmc systemd[1]: Finished Set POWER host firmware well-known names.
Sep 17 14:19:26 p10bmc systemd[1]: Starting Update BIOS attr table with host firmware well-known names...
Sep 17 14:19:26 p10bmc systemd[1]: openpower-update-bios-attr-table.service: Deactivated successfully.
Sep 17 14:19:26 p10bmc systemd[1]: Finished Update BIOS attr table with host firmware well-known names.

Change-Id: I3bc0366a38676d391e1087c27f2fcff487ac5914
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
1 file changed
tree: 37edeecd0985c6d868f2ba7f2a38e9d64cd59904
  1. dbus/
  2. mmc/
  3. static/
  4. test/
  5. ubi/
  6. vpnor/
  7. .clang-format
  8. .gitignore
  9. .shellcheck
  10. activation.cpp
  11. activation.hpp
  12. functions.cpp
  13. functions.hpp
  14. generate-tar
  15. generate-ubi
  16. image_verify.cpp
  17. image_verify.hpp
  18. item_updater.cpp
  19. item_updater.hpp
  20. item_updater_main.cpp
  21. LICENSE
  22. MAINTAINERS
  23. meson.build
  24. meson_options.txt
  25. msl_verify.cpp
  26. msl_verify.hpp
  27. msl_verify_main.cpp
  28. op-pnor-msl.service
  29. openpower-pnor-update@.service
  30. org.open_power.Software.Host.Updater.service
  31. OWNERS
  32. README.md
  33. utils.cpp
  34. utils.hpp
  35. version.cpp
  36. version.hpp
README.md

openpower-pnor-code-mgmt

OpenPower PNOR (Processor NOR) Code Management provides a set of host software management applications for OpenPower systems. The host firmware is stored on the PNOR chip. More information can be found at Software Architecture or Host Code Update

To Build

To build this package, do the following steps:

  1. meson build
  2. ninja -C build

To clean the repository run rm -r build.