Fix ECC usage of being cleaned partitions
Reset procedure of PNOR works improperly for our P8 based VESNIN
hardware and makes the host unbootable.
The problem is in incorrect partition cleaning.
Hostboot for P8 has no support for CLEARECC bit and PNOR flash has no
partitions with flag 'C'.
P9 based hardware is not affected until PNOR has partitions with ECC
flag only.
This commit modifies the reset procedure to make it use the flag 'E'
(ECC) instead of 'C' (CLEARECC).
* The flag 'E' means that the partition requires ECC.
* The flag 'C' means that the partition might be cleaned by hostboot
when ECC is wrong.
For details see:
https://github.com/open-power/hostboot/blob/75c0908b91275dc10bd17cb0f10b452f32ce0b91/src/include/usr/pnor/pnor_const.H#L128
Tested: All PNOR partitions with enabled flags 'E' and 'F' should be
cleaned with ECC.
Change-Id: I632e90c8e256df3445fc3d1f45c830d155a1d208
Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
diff --git a/static/item_updater_static.cpp b/static/item_updater_static.cpp
index b79028b..e867a83 100644
--- a/static/item_updater_static.cpp
+++ b/static/item_updater_static.cpp
@@ -147,7 +147,7 @@
// Each line looks like
// ID=06 MVPD 0x0012d000..0x001bd000 (actual=0x00090000) [E--P--F-C-]
// Flag 'F' means REPROVISION
- // Flag 'C' means CLEARECC
+ // Flag 'E' means ECC required
auto pos = line.find('[');
if (pos == std::string::npos)
{
@@ -178,7 +178,7 @@
}
line = line.substr(0, pos); // The part name
- bool ecc = flags.find('C') != std::string::npos;
+ bool ecc = flags.find('E') != std::string::npos;
ret.emplace_back(line, ecc);
}
}