commit 006641ef0b485c2be0bbffdbc3e8d77327051cad
author Jayanth Othayoth <ojayanth@in.ibm.com> Thu Oct 07 06:56:24 2021 -0500
committer Jayanth Othayoth <ojayanth@in.ibm.com> Mon Oct 18 02:03:23 2021 -0500
tree 282ac56ae4dfabb47cbf7f93e1d2da688bc2250b
parent 21a889fd116971f24cefe9331f3824f3099a290a

PHAL: collect sbe dump for the sbe boot timeout

Added support to collect dump during sbe boot timeout failure.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I88d6eb3c09094721db048c4f90d0d5008eac2cce

extensions/phal/phal_error.cpp

diff --git a/extensions/phal/phal_error.cpp b/extensions/phal/phal_error.cpp
index b6dc1d7..2ef0cc0 100644
--- a/extensions/phal/phal_error.cpp
+++ b/extensions/phal/phal_error.cpp
@@ -4,6 +4,7 @@
 }
 
 #include "create_pel.hpp"
+#include "dump_utils.hpp"
 #include "extensions/phal/common_utils.hpp"
 #include "phal_error.hpp"
 
@@ -555,21 +556,40 @@
         dumpIsRequired = true;
     }
 
+    std::string event;
+
     if ((sbeError.errType() == SBE_FFDC_NO_DATA) ||
         (sbeError.errType() == SBE_CMD_TIMEOUT) || (dumpIsRequired))
     {
-        // Create SBE Dump type error log and trigger Dump
-        openpower::pel::createPEL(
-            "org.open_power.Processor.Error.SbeBootTimeout", pelAdditionalData);
-        // TODO Add dump request
-        return;
+        event = "org.open_power.Processor.Error.SbeBootTimeout";
+        dumpIsRequired = true;
+    }
+    else
+    {
+        event = "org.open_power.Processor.Error.SbeBootFailure";
     }
     // SRC6 : [0:15] chip position
-    uint32_t word6 = pdbg_target_index(procTarget);
-    pelAdditionalData.emplace_back("SRC6", std::to_string(word6 << 16));
+    uint32_t index = pdbg_target_index(procTarget);
+    pelAdditionalData.emplace_back("SRC6", std::to_string(index << 16));
     // Create SBE Error with FFDC data.
-    createSbeErrorPEL("org.open_power.Processor.Error.SbeBootFailure", sbeError,
-                      pelAdditionalData);
+    auto logId = createSbeErrorPEL(event, sbeError, pelAdditionalData);
+
+    if (dumpIsRequired)
+    {
+        using namespace openpower::phal::dump;
+        DumpParameters dumpParameters = {logId, index, SBE_DUMP_TIMEOUT,
+                                         DumpType::SBE};
+        try
+        {
+            requestDump(dumpParameters);
+        }
+        catch (const std::runtime_error& e)
+        {
+            // Allowing call back to handle the error gracefully.
+            log<level::ERR>("Dump collection failed");
+            // TODO revist error handling.
+        }
+    }
 }
 
 void reset()