Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-proc-control / 99ee5ca9c36ff8d80d683337cf81241480b2a200
commit99ee5ca9c36ff8d80d683337cf81241480b2a200[log] [tgz]
authorAndrew Geissler <geissonator@yahoo.com>Thu Feb 04 13:27:06 2021 -0600
committerAndrew Geissler <geissonator@yahoo.com>Thu Feb 04 13:27:06 2021 -0600
tree1364b40c6535cc4884b23f70d1c950abe54557ea
parentea0fb6fc4cc843122809c21f9f41048f394b40e3 [diff]
fix dependency issue between mpreboot and stop instr

During some testing of the mpreboot function, I noticed this journal
log:

Feb 04 17:12:05 bmc systemd[1]: op-stop-instructions@0.service: Found ordering cycle on op-enter-mpreboot@0.service/start
Feb 04 17:12:05 bmc systemd[1]: op-stop-instructions@0.service: Found dependency on obmc-host-stopped@0.target/start
Feb 04 17:12:05 bmc systemd[1]: op-stop-instructions@0.service: Found dependency on obmc-host-stopping@0.target/start
Feb 04 17:12:05 bmc systemd[1]: op-stop-instructions@0.service: Found dependency on op-stop-instructions@0.service/start
Feb 04 17:12:05 bmc systemd[1]: op-stop-instructions@0.service: Job obmc-host-stopped@0.target/start deleted to break ordering cycle starting with op-stop-instructions@0.service/start

The issue is that op-enter-mpreboot@.service says it has to run after
the host has been stopped, but before op-stop-instructions@.service.
This is because op-enter-mpreboot@.service creates the file which tells
op-stop-instructions@.service to not run. op-stop-instructions@.service
is what causes the host to stop, so we end up with a cyclical
dependency.

To fix this, just have op-enter-mpreboot@.service run during the same
target as op-stop-instructions@.service. The only service run here in
that window is op-stop-instructions@service anyway.

This was all a result of the request we not run
op-stop-instructions@.service in the mpreboot path.

Tested: Verified I no longer see the error messages above during a
        mpreboot.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ied611bad3727a11a76aae48ff0a81c30a35952b2
1 file changed
tree: 1364b40c6535cc4884b23f70d1c950abe54557ea
  1. phalerror/
  2. procedures/
  3. test/
  4. .clang-format
  5. .gitignore
  6. bootstrap.sh
  7. cfam_access.cpp
  8. cfam_access.hpp
  9. configure.ac
  10. ext_interface.cpp
  11. ext_interface.hpp
  12. filedescriptor.cpp
  13. filedescriptor.hpp
  14. gen_makefile.sh
  15. LICENSE
  16. MAINTAINERS
  17. Makefile.am
  18. Makefile.generated.in
  19. meson.build
  20. meson_options.txt
  21. nmi_interface.cpp
  22. nmi_interface.hpp
  23. nmi_main.cpp
  24. op-cfam-reset.service.in
  25. op-continue-mpreboot@.service.in
  26. op-enter-mpreboot@.service.in
  27. op-stop-instructions@.service.in
  28. p10_cfam.hpp
  29. p9_cfam.hpp
  30. pcie-poweroff@.service.in
  31. phal-reinit-devtree.service.in
  32. proc-pre-poweroff@.service.in
  33. proc_control.cpp
  34. README.md
  35. registration.cpp
  36. registration.hpp
  37. set-spi-mux.service.in
  38. targeting.cpp
  39. targeting.hpp
  40. xyz.openbmc_project.Control.Host.NMI.service.in
README.md

Contains procedures that interact with the OpenPower nest chipset.

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To build with phal feature:
    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS} --enable-phal --enable-openfsi
    3. make

To clean the repository run `./bootstrap.sh clean`.