Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-proc-control / 3b59356a124d457738327352ba7bb6463730da9c
commit3b59356a124d457738327352ba7bb6463730da9c[log] [tgz]
authorDeepa Karthikeyan <deepakala.karthikeyan@ibm.com>Thu Oct 12 01:27:54 2023 -0500
committerDeepa Karthikeyan <deepakala.karthikeyan@ibm.com>Thu Oct 12 06:14:58 2023 -0500
tree6d14968e678a43714d2154c32be454e61a739fad
parent773fd244bbf229c8ece3a1fcf7944486d2fed1f9 [diff]
PHAL:Fix missing clock diagnostic data during ipl

During the IPL process, the Chassis Power State D-Bus property is
updated once all services and targets within the Chassis Power On target
have been completed. During this specific timeframe, when the
"op-clock-data-logger@.service.in" initiates, it may fail to capture
clock data due to a failed check. This situation occurs because, even
though the chassis power is turned on, the D-Bus property does not
provide the precise status, resulting in a missed opportunity to record
informational clock data.

The "op-clock-data-logger@.service.in" service is already configured to
start after the "obmc-host-started@%i.target" and is set to conflict
with the "obmc-host-stop@%i.target." This design ensures that whenever
this method is invoked, the chassis power will always be in the ON
state. Therefore, there is no need to redundantly check the chassis
power state for being ON. Consequently, the redundant conditional
statement has been removed.

Tested and found the clock informational diagnostic data added after
every ipl.

Change-Id: I56e62467be14c6f203d163d86aa6a5fd748d0d85
Signed-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>
1 file changed
tree: 6d14968e678a43714d2154c32be454e61a739fad
  1. extensions/
  2. procedures/
  3. service_files/
  4. test/
  5. .clang-format
  6. .gitignore
  7. .shellcheck
  8. cfam_access.cpp
  9. cfam_access.hpp
  10. ext_interface.cpp
  11. ext_interface.hpp
  12. filedescriptor.cpp
  13. filedescriptor.hpp
  14. LICENSE
  15. meson.build
  16. meson.options
  17. nmi_interface.cpp
  18. nmi_interface.hpp
  19. nmi_main.cpp
  20. OWNERS
  21. p10_cfam.hpp
  22. p9_cfam.hpp
  23. proc_control.cpp
  24. README.md
  25. registration.hpp
  26. targeting.cpp
  27. targeting.hpp
  28. temporary_file.cpp
  29. temporary_file.hpp
  30. util.cpp
  31. util.hpp
README.md

Contains procedures that interact with the OpenPower nest chipset.

To Build

To build this package, do the following steps:

    1. meson builddir
    2. ninja -C builddir

To build with phal feature:
    1. meson builddir -Dphal=enabled -Dopenfsi=enabled
    2. ninja -C builddir

To clean the repository run `ninja -C builddir/ clean`.