commit 63508a73e0eb47760ca2520517b16f6a9d177db2
author Brad Bishop <bradleyb@fuzziesquirrel.com> Tue Oct 27 18:55:01 2020 -0400
committer Jayanth Othayoth <ojayanth@in.ibm.com> Fri Oct 30 02:37:57 2020 +0000
tree ac24c3fa62efece97b39defc3421267563d2c913
parent 56d14d049bcb1966fac953d1bf07a9e5bedf5ebc

fix compiler warnings

Fix a couple pedantic, format=, and unused-parameter warnings so we can
turn the warnings all the way up.

Change-Id: I7c6309e30147f54fc64ace99dc784fbd96c77c70
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

procedures/common/cfam_overrides.cpp

diff --git a/procedures/common/cfam_overrides.cpp b/procedures/common/cfam_overrides.cpp
index 13f7659..ea311f5 100644
--- a/procedures/common/cfam_overrides.cpp
+++ b/procedures/common/cfam_overrides.cpp
@@ -27,7 +27,7 @@
 
 void CFAMOverride()
 {
-    int pos = 0;
+    size_t pos = 0;
     cfam_address_t address = 0;
     cfam_data_t data = 0;
     cfam_mask_t mask = 0;
@@ -48,7 +48,7 @@
                 if (!line.empty() && line.at(0) != '#')
                 {
                     mask = 0xFFFFFFFF;
-                    if (sscanf(line.c_str(), "%x %hx %x %x", &pos, &address,
+                    if (sscanf(line.c_str(), "%zu %hx %x %x", &pos, &address,
                                &data, &mask) >= 3)
                     {
                         const auto& target = targets.getTarget(pos);
@@ -74,7 +74,7 @@
     return;
 }
 
-REGISTER_PROCEDURE("CFAMOverride", CFAMOverride);
+REGISTER_PROCEDURE("CFAMOverride", CFAMOverride)
 
 } // namespace p9
 } // namespace openpower

procedures/common/cfam_reset.cpp

diff --git a/procedures/common/cfam_reset.cpp b/procedures/common/cfam_reset.cpp
index acf3d3d..9a09d18 100644
--- a/procedures/common/cfam_reset.cpp
+++ b/procedures/common/cfam_reset.cpp
@@ -68,7 +68,7 @@
     line.set_value(1);
 }
 
-REGISTER_PROCEDURE("cfamReset", cfamReset);
+REGISTER_PROCEDURE("cfamReset", cfamReset)
 
 } // namespace misc
 } // namespace openpower

procedures/common/collect_sbe_hb_data.cpp

diff --git a/procedures/common/collect_sbe_hb_data.cpp b/procedures/common/collect_sbe_hb_data.cpp
index 6cba8ee..d810c02 100644
--- a/procedures/common/collect_sbe_hb_data.cpp
+++ b/procedures/common/collect_sbe_hb_data.cpp
@@ -137,7 +137,7 @@
     }
 }
 
-REGISTER_PROCEDURE("collectSBEHBData", collectSBEHBData);
+REGISTER_PROCEDURE("collectSBEHBData", collectSBEHBData)
 
 } // namespace debug
 } // namespace p9

procedures/common/enter_mpreboot.cpp

diff --git a/procedures/common/enter_mpreboot.cpp b/procedures/common/enter_mpreboot.cpp
index 3c6e2e0..48e6ff3 100644
--- a/procedures/common/enter_mpreboot.cpp
+++ b/procedures/common/enter_mpreboot.cpp
@@ -14,11 +14,14 @@
  * limitations under the License.
  */
 
+#include "registration.hpp"
+
 #include <libpdbg.h>
 #include <sys/wait.h>
 #include <unistd.h>
 
 #include <phosphor-logging/log.hpp>
+#include <system_error>
 #include <vector>
 
 namespace openpower
@@ -98,7 +101,7 @@
     }
 }
 
-REGISTER_PROCEDURE("enterMpReboot", enterMpReboot);
+REGISTER_PROCEDURE("enterMpReboot", enterMpReboot)
 
 } // namespace misc
 } // namespace openpower