Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-proc-control / d7469407ec4d45cc1c1bd3704be18c7ba7ecdcda
commitd7469407ec4d45cc1c1bd3704be18c7ba7ecdcda[log] [tgz]
authorJayanth Othayoth <ojayanth@in.ibm.com>Tue Mar 08 03:06:44 2022 -0600
committerJayanth Othayoth <ojayanth@in.ibm.com>Tue Mar 08 04:28:23 2022 -0600
tree3ba9fa2d027af4ee14f0a88a8b7e31a54227b9ed
parent750f9227ce9555f381c72ea96bbe2cfce155343a [diff]
PHAL: istep mode: hardware error is not stopping boot process.

In the istep mode an error is logged with hardware error
should stop the boot process and stays in Quiesce state  if the
stop on error  policy is enabled.
Noticed diffrent behaviour in istep mode, like Quiesce calls
phal-create-boottime-guard-indicator.service. This service
starts start_host@0.service, causing normal boot start in the
middle of a Quiesce.

In most cases, this would be fine, but we didn't use firmware
to boot so we did not run "start_host@0.service".

Proposed fix is to remove Wants=start_host@0.service

Tested: forced the checkstop during istep boot.
        system stay's at Quiesce state.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I4c11648f9162e2c0c861cb1c96edafd6e22323b6
1 file changed
tree: 3ba9fa2d027af4ee14f0a88a8b7e31a54227b9ed
  1. extensions/
  2. procedures/
  3. service_files/
  4. test/
  5. .clang-format
  6. .gitignore
  7. .shellcheck
  8. cfam_access.cpp
  9. cfam_access.hpp
  10. ext_interface.cpp
  11. ext_interface.hpp
  12. filedescriptor.cpp
  13. filedescriptor.hpp
  14. LICENSE
  15. MAINTAINERS
  16. meson.build
  17. meson_options.txt
  18. nmi_interface.cpp
  19. nmi_interface.hpp
  20. nmi_main.cpp
  21. OWNERS
  22. p10_cfam.hpp
  23. p9_cfam.hpp
  24. proc_control.cpp
  25. README.md
  26. registration.hpp
  27. targeting.cpp
  28. targeting.hpp
  29. temporary_file.cpp
  30. temporary_file.hpp
  31. util.cpp
  32. util.hpp
README.md

Contains procedures that interact with the OpenPower nest chipset.

To Build

To build this package, do the following steps:

    1. meson builddir
    2. ninja -C builddir

To build with phal feature:
    1. meson builddir -Dphal=enabled -Dopenfsi=enabled
    2. ninja -C builddir

To clean the repository run `ninja -C builddir/ clean`.