| commit | cb3d1dba4fc1f75ff8ed48f3f30012f184adf2cb | [log] [tgz] |
|---|---|---|
| author | Andrew Geissler <geissonator@yahoo.com> | Thu Jun 02 15:19:06 2022 -0400 |
| committer | Andrew Geissler <andrew@geissonator.com> | Tue Jul 19 12:58:51 2022 +0000 |
| tree | c09776db521af5e509d3ffa1c8c8a4bc4fc06495 | |
| parent | d8be1ebda3961b442d60e75d50a49c3477c3edf2 [diff] |
remove wants on synch targets in stop-instructions openbmc/phosphor-state-manager#21 highlights an architecture issue with OpenBMC's use of synchronization targets. When a service, such as op-stop-instructions@.service, runs both in a standard power off target, as well as in other paths (like the host quiesce path), there is an issue. The service starts the synchronization targets in the quiesce path and this causes them to already be running on the power off, resulting in the synchronization targets not actually coordinating the power off. The direction this commit takes OpenBMC is that if a service needs to run outside of the standard power on or off path, then they can not have a Wants or Requires clause in the service file. The following commit was done a while back to address this issue: https://gerrit.openbmc.org/c/openbmc/phosphor-state-manager/+/40026 That is that we ensure the primary power on and off targets start the synchronization targets so services requiring them can just use a Before or After clause. The piece that was never done was to go and fix the services which fell into this bucket. Tested: - Did multiple boots, reboots, and host crash tests and saw no issues Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: Ida68d83e2c2c18484eb4f28bc55c91fa5ff94930
Contains procedures that interact with the OpenPower nest chipset.
To build this package, do the following steps:
1. meson builddir
2. ninja -C builddir
To build with phal feature:
1. meson builddir -Dphal=enabled -Dopenfsi=enabled
2. ninja -C builddir
To clean the repository run `ninja -C builddir/ clean`.