utilize systemd semantic for non-critical ExecStart
The "|| true" was always a bit of a hack to have systemd services ignore
commands which are not critical. It seems recent systemd releases have
broken that workaround.
Utilize the official[1] systemd mechanism to indicate a command within
the service is optional and ok to fail (=-).
The location of the "|| true" within the commands quotation marks
now matters. But lets just get rid of it all together now that we have a
way to just have systemd allow the command to fail and continue.
Tested:
Wrote a little test service:
```
[Unit]
Description=Test Service
[Service]
RemainAfterExit=yes
Type=oneshot
ExecStart=/bin/sh -c "busctl set-property invalid || true"
ExecStart=-/bin/sh -c "busctl set-property invalid" || true
ExecStart=-/bin/sh -c "busctl set-property invalid"
ExecStart=/bin/echo 'we made it past all invalid tests above'
[Install]
```
[1]: https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Command%20lines
Change-Id: I5b16a5abf9ba8e0a384bac1130b77bf0252b9dd9
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
diff --git a/service_files/op-stop-instructions@.service.in b/service_files/op-stop-instructions@.service.in
index 8fada7e..63617cc 100644
--- a/service_files/op-stop-instructions@.service.in
+++ b/service_files/op-stop-instructions@.service.in
@@ -13,7 +13,7 @@
RemainAfterExit=yes
Type=oneshot
TimeoutStartSec=20
-ExecStart=/bin/sh -c 'systemctl stop attn_handler.service || true'
+ExecStart=-/bin/sh -c 'systemctl stop attn_handler.service'
ExecStart=/usr/bin/openpower-proc-control threadStopAll
[Install]