Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-proc-control / ea0fb6fc4cc843122809c21f9f41048f394b40e3
commitea0fb6fc4cc843122809c21f9f41048f394b40e3[log] [tgz]
authorAndrew Geissler <geissonator@yahoo.com>Fri Jan 08 12:53:43 2021 -0600
committerAndrew Geissler <geissonator@yahoo.com>Fri Jan 08 13:29:21 2021 -0600
treebf2e09b76cc93db3f10fd012d418a411d8e1e0b9
parent87266c597307175d3f821abe46a98e70144e4a2b [diff]
add timeout to stop-instructions service

Stopping instructions on POWER based systems is a fairly complicated
process with a lot of moving parts. If one of these moving parts gets
hung up, the entire power off process gets hung up. This issue has been
seen intermittently over the years on different systems so for safety,
lets put a timeout in the service.

Stopping instructions is not a requirement to power off, it's just a
nice-to-have type function. Don't let it hanging prevent the overall
powering off of the system.

Note that this commit also moves the rm of the host@%i-on file to being
first. This is to ensure it always runs, even if the pdbg command times
out and causes the service to fail.

Tested:
- Verified on good path stop instructions takes 2-4 seconds.
- Verified when I caused this service to hang, we hit timeout and
  powered off system.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I7d249051634aeca399e2ecf6d24bca5e19637160
1 file changed
tree: bf2e09b76cc93db3f10fd012d418a411d8e1e0b9
  1. phalerror/
  2. procedures/
  3. test/
  4. .clang-format
  5. .gitignore
  6. bootstrap.sh
  7. cfam_access.cpp
  8. cfam_access.hpp
  9. configure.ac
  10. ext_interface.cpp
  11. ext_interface.hpp
  12. filedescriptor.cpp
  13. filedescriptor.hpp
  14. gen_makefile.sh
  15. LICENSE
  16. MAINTAINERS
  17. Makefile.am
  18. Makefile.generated.in
  19. meson.build
  20. meson_options.txt
  21. nmi_interface.cpp
  22. nmi_interface.hpp
  23. nmi_main.cpp
  24. op-cfam-reset.service.in
  25. op-continue-mpreboot@.service.in
  26. op-enter-mpreboot@.service.in
  27. op-stop-instructions@.service.in
  28. p10_cfam.hpp
  29. p9_cfam.hpp
  30. pcie-poweroff@.service.in
  31. phal-reinit-devtree.service.in
  32. proc-pre-poweroff@.service.in
  33. proc_control.cpp
  34. README.md
  35. registration.cpp
  36. registration.hpp
  37. set-spi-mux.service.in
  38. targeting.cpp
  39. targeting.hpp
  40. xyz.openbmc_project.Control.Host.NMI.service.in
README.md

Contains procedures that interact with the OpenPower nest chipset.

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To build with phal feature:
    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS} --enable-phal --enable-openfsi
    3. make

To clean the repository run `./bootstrap.sh clean`.