utilize systemd semantic for non-critical ExecStart

The "|| true" was always a bit of a hack to have systemd services ignore
commands which are not critical. It seems recent systemd releases have
broken that workaround.

Utilize the official[1] systemd mechanism to indicate a command within
the service is optional and ok to fail (=-).

The location of the "|| true" within the commands quotation marks
now matters. But lets just get rid of it all together now that we have a
way to just have systemd allow the command to fail and continue.

Tested:
Wrote a little test service:
```
[Unit]
Description=Test Service

[Service]
RemainAfterExit=yes
Type=oneshot
ExecStart=/bin/sh -c "busctl set-property invalid || true"
ExecStart=-/bin/sh -c "busctl set-property invalid" || true
ExecStart=-/bin/sh -c "busctl set-property invalid"
ExecStart=/bin/echo 'we made it past all invalid tests above'

[Install]

```

[1]: https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Command%20lines

Change-Id: I5b16a5abf9ba8e0a384bac1130b77bf0252b9dd9
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2 files changed
tree: 2af9f3895bf6fc152f2c310abf859b741bc5381e
  1. extensions/
  2. procedures/
  3. service_files/
  4. subprojects/
  5. test/
  6. .clang-format
  7. .gitignore
  8. .shellcheck
  9. cfam_access.cpp
  10. cfam_access.hpp
  11. ext_interface.cpp
  12. ext_interface.hpp
  13. filedescriptor.cpp
  14. filedescriptor.hpp
  15. LICENSE
  16. meson.build
  17. meson.options
  18. nmi_interface.cpp
  19. nmi_interface.hpp
  20. nmi_main.cpp
  21. OWNERS
  22. p10_cfam.hpp
  23. p9_cfam.hpp
  24. proc_control.cpp
  25. README.md
  26. registration.hpp
  27. targeting.cpp
  28. targeting.hpp
  29. temporary_file.cpp
  30. temporary_file.hpp
  31. util.cpp
  32. util.hpp
README.md

openpower-proc-control

Contains procedures that interact with the OpenPower nest chipset.

To Build

To build this package, do the following steps:

1. meson builddir
2. ninja -C builddir

To build with phal feature:

1. meson builddir -Dphal=enabled -Dopenfsi=enabled
2. ninja -C builddir

To clean the repository run ninja -C builddir/ clean.