Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / 02d4d4eaffd6d1addd243316834f4a60f595de02
commit02d4d4eaffd6d1addd243316834f4a60f595de02[log] [tgz]
authorPriyangaRamasamy <priyanga24@in.ibm.com>Mon Feb 24 14:54:45 2020 +0530
committerPriyanga Ramasamy <priyanga24@in.ibm.com>Sun Jun 21 16:58:30 2020 +0000
tree2d9f17c376de2daaff86d0b8c7a07af6420f80bd
parent1f0b1e6d2aaaebdabc2767081e809b5486ef9223 [diff]
VPD tool : Read Keyword option

One of the options the VPD tool provides is
to Read the value of the keyword. This commit has its implementation.

The user should provide a valid object path, valid record name
and valid keyword inorder to get the value of the keyword.

Test:
Tested on simics.

Output:

root@rainier:/tmp# ./vpd-tool -r -O /system/chassis/motherboard/vdd_vrm1 -R VINI -K FN
{
    "/system/chassis/motherboard/vdd_vrm1": {
        "FN": "F190827"
    }
}

Signed-off-by: PriyangaRamasamy <priyanga24@in.ibm.com>
Change-Id: I244b9fe276feefa27e4c99063a9e9aa01aeb2f12
5 files changed
tree: 2d9f17c376de2daaff86d0b8c7a07af6420f80bd
  1. examples/
  2. test/
  3. vpdecc/
  4. .clang-format
  5. .gitignore
  6. app.cpp
  7. args.cpp
  8. args.hpp
  9. bootstrap.sh
  10. configure.ac
  11. defines.hpp
  12. extra-properties-example.yaml
  13. extra-properties.mako.hpp
  14. extra-properties.py
  15. ibm_vpd_app.cpp
  16. ibm_vpd_type_check.cpp
  17. ibm_vpd_type_check.hpp
  18. impl.cpp
  19. impl.hpp
  20. keyword_vpd_parser.cpp
  21. keyword_vpd_parser.hpp
  22. keyword_vpd_types.hpp
  23. LICENSE
  24. MAINTAINERS
  25. Makefile.am
  26. meson.build
  27. meson_options.txt
  28. parser.cpp
  29. parser.hpp
  30. README.md
  31. store.hpp
  32. types.hpp
  33. utils.cpp
  34. utils.hpp
  35. vpd_tool.cpp
  36. vpd_tool_impl.cpp
  37. vpd_tool_impl.hpp
  38. write.cpp
  39. write.hpp
  40. writefru.mako.hpp
  41. writefru.py
  42. writefru.yaml
README.md

#Overview This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.