Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / afb71f75447d8ec76122b948deace54ce0be35d9
commitafb71f75447d8ec76122b948deace54ce0be35d9[log] [tgz]
authorPriyanga Ramasamy <priyanga24@in.ibm.com>Fri Oct 21 02:17:19 2022 -0500
committerSantosh Puranik <santosh.puranik@in.ibm.com>Thu Nov 03 09:01:21 2022 +0000
tree6651afe9f951fbf0918a42ff264931c11b9c47b3
parentda3b2d2507797a3aefcfe37622fab63415a7406b [diff]
Include VSYS FV in restorable keywords list

There is a new requirement to restore VSYS FV keyword
along with other system backplane keywords.

Along with this change, increased the table size in vpd-tool
fixSystemVPD code, so that keyword FV which is of 32 bytes can
fit in that table.

Test:
CASE 1: Automatic restore via vpd-manager
./vpd-tool -r -O /system/chassis/motherboard -R VSYS -K FV
{
    "/system/chassis/motherboard": {
        "FV": "ab"
    }
}

./vpd-tool -r -H -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -R VSYS -K FV
{
    "/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
        "FV": "                                "
    }
}

systemctl restart com.ibm.VPD.Manager.service

./vpd-tool -r -H -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -R VSYS -K FV
{
    "/sys/bus/i2c/drivers/at24/8-0050/eeprom": {
        "FV": "ab                              "
    }
}

./vpd-tool -r -O /system/chassis/motherboard -R VSYS -K FV
{
    "/system/chassis/motherboard": {
        "FV": "ab"
    }
}

CASE 2: Restore using vpd-tool command
====================================================================================================================================================================================================
S.No  Record  Keyword  Data On BMC                                                                     Data On System Backplane                                                        Data Mismatch
12    VSYS    FV       0x6162202020202020202020202020202020202020202020202020202020202020              0x6162202020202020202020202020202020202020202020202020202020202020              NO
====================================================================================================================================================================================================

No mismatch found.

Enter 6 => If you wish to enter a new value to update both on BMC and System Backplane
Enter 7 => If you wish to skip the above record-keyword pair
Enter 0 => To exit successfully : 6

====================================================================================================================================================================================================

Enter the new value to update both on BMC & System Backplane (Value should be in ASCII or in HEX(prefixed with 0x)) : 0x2020202020202020202020202020202020202020202020202020202020202020

====================================================================================================================================================================================================

Data updated successfully.

Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
Change-Id: I1048e1cc39249f587355597e42a6749a1cb01fa5
1 file changed
tree: 6651afe9f951fbf0918a42ff264931c11b9c47b3
  1. examples/
  2. subprojects/
  3. test/
  4. vpd-manager/
  5. vpd-parser/
  6. vpdecc/
  7. .clang-format
  8. .gitignore
  9. app.cpp
  10. args.cpp
  11. args.hpp
  12. common_utility.cpp
  13. common_utility.hpp
  14. const.hpp
  15. defines.hpp
  16. extra-properties-example.yaml
  17. extra-properties.mako.hpp
  18. extra-properties.py
  19. ibm_vpd_app.cpp
  20. ibm_vpd_utils.cpp
  21. ibm_vpd_utils.hpp
  22. impl.cpp
  23. impl.hpp
  24. LICENSE
  25. meson.build
  26. meson_options.txt
  27. OWNERS
  28. README.md
  29. store.hpp
  30. types.hpp
  31. utilInterface.hpp
  32. vpd_exceptions.hpp
  33. vpd_tool.cpp
  34. vpd_tool_impl.cpp
  35. vpd_tool_impl.hpp
  36. write.cpp
  37. write.hpp
  38. writefru.mako.hpp
  39. writefru.py
  40. writefru.yaml
README.md

Overview

This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.