Handle ECC update
By default openpower-vpd-parser contains dummy code of ecc_create
which writes 0s to the vpd-ecc. And this corrupts the ECC.
This commit will not allow the user to update any record-kwd-data
with dummy ecc_create code as it returns -1. If want to update any vpd
data then build your image with vpdecc functions implementation.
Test-
when tried to update the keyword-
busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager com.ibm.VPD.Manager WriteKeyword ossay "/system/chassis/motherboard" "VINI" "PN" 1 65
ERROR: ECC update failed
And another terminal output-
root@rainier:/tmp# ./vpd-manager
Error: Couldn't update the ECC
Signed-off-by: Alpana Kumari <alpankum@in.ibm.com>
Change-Id: I7333a79ff06ac1acd21f9e10f99b4a78cb5705db
diff --git a/test/vpd-manager-test/editor_test.cpp b/test/vpd-manager-test/editor_test.cpp
index f20f465..b6fcfa8 100644
--- a/test/vpd-manager-test/editor_test.cpp
+++ b/test/vpd-manager-test/editor_test.cpp
@@ -161,14 +161,13 @@
try
{
- // All valid data
+ // All valid data, but can't update with dummy ECC code
EditorImpl edit("VINI", "SN", std::move(vpd));
edit.updateKeyword(dataToUodate, 0, true);
}
catch (const std::runtime_error& e)
{
- EXPECT_EQ(std::string(e.what()),
- std::string("Data updated successfully"));
+ EXPECT_EQ(std::string(e.what()), std::string("Ecc update failed"));
}
}