Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / 16c634f7c7a3b7a20f9652582ada1959c7517fa6
commit16c634f7c7a3b7a20f9652582ada1959c7517fa6[log] [tgz]
authorSantosh Puranik <santosh.puranik@in.ibm.com>Tue Jul 28 11:10:27 2020 +0530
committerSantosh Puranik <santosh.puranik@in.ibm.com>Tue Jul 28 11:10:27 2020 +0530
tree68cd364aedb2fcdb1397e370cb9e7127232d0fdf
parenta0d460e2cfda64cc609347cdc4735e2cca1d6e43 [diff]
Fix infinite recursion

This commit fixes an idefinite recursion in
utility::readBusProperty by using a fully qualified
name for openpower::vpd::readBusProperty.

Tested:
Make sure calls to VPD manager work.

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: I70b0c29333a38705ccaaa54134d80b6c14e61832
1 file changed
tree: 68cd364aedb2fcdb1397e370cb9e7127232d0fdf
  1. examples/
  2. test/
  3. vpd-manager/
  4. vpdecc/
  5. .clang-format
  6. .gitignore
  7. app.cpp
  8. args.cpp
  9. args.hpp
  10. bootstrap.sh
  11. configure.ac
  12. const.hpp
  13. defines.hpp
  14. extra-properties-example.yaml
  15. extra-properties.mako.hpp
  16. extra-properties.py
  17. ibm_vpd_app.cpp
  18. ibm_vpd_type_check.cpp
  19. ibm_vpd_type_check.hpp
  20. impl.cpp
  21. impl.hpp
  22. keyword_vpd_parser.cpp
  23. keyword_vpd_parser.hpp
  24. keyword_vpd_types.hpp
  25. LICENSE
  26. MAINTAINERS
  27. Makefile.am
  28. meson.build
  29. meson_options.txt
  30. parser.cpp
  31. parser.hpp
  32. README.md
  33. store.hpp
  34. types.hpp
  35. utilInterface.hpp
  36. utils.cpp
  37. utils.hpp
  38. vpd_tool.cpp
  39. vpd_tool_impl.cpp
  40. vpd_tool_impl.hpp
  41. write.cpp
  42. write.hpp
  43. writefru.mako.hpp
  44. writefru.py
  45. writefru.yaml
README.md

#Overview This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.