Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / 0d61c58864a978723b84bafd8d5703a4f547c909
commit0d61c58864a978723b84bafd8d5703a4f547c909[log] [tgz]
authorPriyanga Ramasamy <priyanga24@in.ibm.com>Fri Jan 21 04:38:22 2022 -0600
committerPriyanga Ramasamy <priyanga24@in.ibm.com>Mon Feb 14 23:04:11 2022 -0600
treefb7c5c0f26c61d1a329c058676d6930930e22375
parenta0b2391a6ea9b152105a346918cd1c74e17857e4 [diff]
Defect fix:Unexpanded DIMM location codes

Defect:
The DIMM location codes gets its unexpanded version in
the system.
As per the vpd-parser, the dimm location code gets expanded
as a part of priming the inventory. But that expanded version
is getting overridden by the populateInterfaces api, where
the populateInterfaces api has the logic to populate unexpanded
location code in dbus for frus which are not of type IPZ VPD.
DIMM is one such fru which is not of type IPZ VPD.

This commit has a fix to get the location code for VPD of type
Keyword.

Test:
Tested on rainer
root@p10bmc:/tmp# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0
NAME                                                  TYPE      SIGNATURE RESULT/VALUE                             FLAGS
com.ibm.ipzvpd.Location                               interface -         -                                        -
.LocationCode                                         property  s         "Ufcs-P0-C12"                            emits-change writable
com.ibm.ipzvpd.VINI                                   interface -         -

root@p10bmc:/tmp# ./ibm-read-vpd --file /sys/bus/i2c/drivers/at24/111-0050/eeprom
root@p10bmc:/tmp# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0
NAME                                                  TYPE      SIGNATURE RESULT/VALUE                             FLAGS
com.ibm.ipzvpd.Location                               interface -         -                                        -
.LocationCode                                         property  s         "U78DB.ND0.1234567-P0-C12"               emits-change writable
com.ibm.ipzvpd.VINI                                   interface -         -                                        -
.B3                                                   property  ay        0

Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
Change-Id: Ib199c4448d93510e6a517f49eaac94334ffb8951
1 file changed
tree: fb7c5c0f26c61d1a329c058676d6930930e22375
  1. examples/
  2. subprojects/
  3. test/
  4. vpd-manager/
  5. vpd-parser/
  6. vpdecc/
  7. .clang-format
  8. .gitignore
  9. app.cpp
  10. args.cpp
  11. args.hpp
  12. common_utility.cpp
  13. common_utility.hpp
  14. const.hpp
  15. defines.hpp
  16. extra-properties-example.yaml
  17. extra-properties.mako.hpp
  18. extra-properties.py
  19. ibm_vpd_app.cpp
  20. ibm_vpd_utils.cpp
  21. ibm_vpd_utils.hpp
  22. impl.cpp
  23. impl.hpp
  24. LICENSE
  25. MAINTAINERS
  26. meson.build
  27. meson_options.txt
  28. OWNERS
  29. README.md
  30. store.hpp
  31. types.hpp
  32. utilInterface.hpp
  33. vpd_exceptions.hpp
  34. vpd_tool.cpp
  35. vpd_tool_impl.cpp
  36. vpd_tool_impl.hpp
  37. write.cpp
  38. write.hpp
  39. writefru.mako.hpp
  40. writefru.py
  41. writefru.yaml
README.md

Overview

This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.