commit 19be6d3d483fddeea3e24f524cbbfc39dbca20b5
author SunnySrivastava1984 <sunnsr25@in.ibm.com> Tue Mar 03 07:21:45 2020 -0600
committer SunnySrivastava1984 <sunnsr25@in.ibm.com> Mon Jun 22 01:45:33 2020 -0500
tree 35eb7bc1ea51ddb96fa7a5fe520e705c1ef8f95b
parent de3c60de2dd55f8f5038b804723983dbb46bade6

Common file to hold all constant values

This commit introduces a const.hpp file to hold all the
constants related to the openpower vpd repository.
All new and ongoing implementations can make use of this
file to declare or reuse constants.

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: Ib93c1c264dc8c69198140d63318e7e132d33fb13

impl.cpp

diff --git a/impl.cpp b/impl.cpp
index f4d1e42..d647d8b 100644
--- a/impl.cpp
+++ b/impl.cpp
@@ -1,5 +1,6 @@
 #include "impl.hpp"
 
+#include "const.hpp"
 #include "defines.hpp"
 #include "utils.hpp"
 
@@ -20,27 +21,11 @@
 {
 namespace parser
 {
+using namespace openpower::vpd::constants;
 
 static const std::unordered_map<std::string, Record> supportedRecords = {
     {"VINI", Record::VINI}, {"OPFR", Record::OPFR}, {"OSYS", Record::OSYS}};
 
-static constexpr auto MAC_ADDRESS_LEN_BYTES = 6;
-static constexpr auto LAST_KW = "PF";
-static constexpr auto POUND_KW = '#';
-static constexpr auto UUID_LEN_BYTES = 16;
-static constexpr auto UUID_TIME_LOW_END = 8;
-static constexpr auto UUID_TIME_MID_END = 13;
-static constexpr auto UUID_TIME_HIGH_END = 18;
-static constexpr auto UUID_CLK_SEQ_END = 23;
-
-static constexpr auto MB_RESULT_LEN = 19;
-static constexpr auto MB_LEN_BYTES = 8;
-static constexpr auto MB_YEAR_END = 4;
-static constexpr auto MB_MONTH_END = 7;
-static constexpr auto MB_DAY_END = 10;
-static constexpr auto MB_HOUR_END = 13;
-static constexpr auto MB_MIN_END = 16;
-
 static const std::unordered_map<std::string, internal::KeywordInfo>
     supportedKeywords = {
         {"DR", std::make_tuple(record::Keyword::DR, keyword::Encoding::ASCII)},
@@ -57,43 +42,6 @@
         {"VS", std::make_tuple(record::Keyword::VS, keyword::Encoding::ASCII)},
 };
 
-namespace offsets
-{
-
-enum Offsets
-{
-    VHDR = 17,
-    VHDR_TOC_ENTRY = 29,
-    VTOC_PTR = 35,
-    VTOC_DATA = 13,
-    VHDR_ECC = 0,
-    VHDR_RECORD = 11
-};
-}
-
-namespace lengths
-{
-
-enum Lengths
-{
-    RECORD_NAME = 4,
-    KW_NAME = 2,
-    RECORD_MIN = 44,
-    VTOC_RECORD_LENGTH = 14,
-    VHDR_ECC_LENGTH = 11,
-    VHDR_RECORD_LENGTH = 44,
-};
-}
-
-namespace eccStatus
-{
-enum Status
-{
-    SUCCESS = 0,
-    FAILED = -1,
-};
-}
-
 namespace
 {
 constexpr auto toHex(size_t c)