Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / 2fe709f11031c9f447283aaa5316c4d08ba7c34e
commit2fe709f11031c9f447283aaa5316c4d08ba7c34e[log] [tgz]
authorAndrew Geissler <geissonator@yahoo.com>Thu Mar 25 10:59:07 2021 -0500
committerSantosh Puranik <santosh.puranik@in.ibm.com>Thu Apr 01 13:38:10 2021 +0000
tree4aae7a35a718dc0913e7795baab4478b2bd0457b
parent887a42adeda24a05215923208b645ac6a59fdf6e [diff]
support new fitconfig u-boot syntax

The following commit changed the syntax of the fitconfig u-boot
environment variable:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta?id=cfc0e21b1066b5d5d0fc37fbc5d79f40f4576f1d

OpenBMC pulled this in via:
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/41108

The summary is that the "@" symbol was repaced with a "-" symbol.

Because this is a u-boot environment variable which is persistent across
code updates, there is no good way to make this backwards or forwards
compatible with the poky change. It will be up to the system owner to
manage this issue if they are utilizing this fitconfig override feature.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ica16e333e5f9d731ccf8da0048f6d1d2c1cc3bf2
1 file changed
tree: 4aae7a35a718dc0913e7795baab4478b2bd0457b
  1. examples/
  2. test/
  3. vpd-manager/
  4. vpd-parser/
  5. vpdecc/
  6. .clang-format
  7. .gitignore
  8. app.cpp
  9. args.cpp
  10. args.hpp
  11. const.hpp
  12. defines.hpp
  13. extra-properties-example.yaml
  14. extra-properties.mako.hpp
  15. extra-properties.py
  16. ibm_vpd_app.cpp
  17. impl.cpp
  18. impl.hpp
  19. LICENSE
  20. MAINTAINERS
  21. meson.build
  22. meson_options.txt
  23. README.md
  24. store.hpp
  25. types.hpp
  26. utilInterface.hpp
  27. utils.cpp
  28. utils.hpp
  29. vpd_exceptions.hpp
  30. vpd_tool.cpp
  31. vpd_tool_impl.cpp
  32. vpd_tool_impl.hpp
  33. write.cpp
  34. write.hpp
  35. writefru.mako.hpp
  36. writefru.py
  37. writefru.yaml
README.md

#Overview This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.