Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / 051b34fb4923b970041ffb58d84f8359d3423d31
commit051b34fb4923b970041ffb58d84f8359d3423d31[log] [tgz]
authorPriyanga Ramasamy <priyanga24@in.ibm.com>Wed Jun 28 00:37:43 2023 -0500
committerPriyanga Ramasamy <priyanga24@in.ibm.com>Mon Jul 10 07:55:15 2023 -0500
tree65c775744929458213b01476f2b98bb5ec3f71e7
parent3fb026386546cfd288ab4f86156c9aa0ffa145d6 [diff]
vpd-tool:Skip displaying Asset interface

vpd-tool by default displays specific VINI properties for all FRUs
which is again displayed as a part of Asset interface properties when
the Asset interface is found in vpd JSON extraInterfaces{}.

To avoid displaying duplicates in vpd-tool, vpd-tool skips displaying
Asset interface properties.

Test:
Tested that no duplicates are found in vpd-tool output.

vpd-tool -o -O /system/chassis/motherboard/fan1
[
    {
        "/system/chassis/motherboard/fan1": {
            "CC": "7B5G",
            "DR": "Fan",
            "FN": "02YK237",
            "LocationCode": "U78DA.ND0.WZS002T-A1",
            "Manufacturer": "Delta",
            "PN": "02YK200",
            "Present": "true",
            "RI": "",
            "RT": "",
            "SN": "YS10JP12V0TY",
            "TYPE": "FRU",
            "type": "xyz.openbmc_project.Inventory.Item.Fan"
        }
    }
]

Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
Change-Id: I6ee4d7210ac9cf5178685a3dbf6581f973dd2235
1 file changed
tree: 65c775744929458213b01476f2b98bb5ec3f71e7
  1. examples/
  2. ibm_vpd/
  3. subprojects/
  4. test/
  5. vpd-manager/
  6. vpd-parser/
  7. vpdecc/
  8. .clang-format
  9. .gitignore
  10. app.cpp
  11. args.cpp
  12. args.hpp
  13. common_utility.cpp
  14. common_utility.hpp
  15. const.hpp
  16. defines.hpp
  17. extra-properties-example.yaml
  18. extra-properties.mako.hpp
  19. extra-properties.py
  20. ibm_vpd_app.cpp
  21. ibm_vpd_utils.cpp
  22. ibm_vpd_utils.hpp
  23. impl.cpp
  24. impl.hpp
  25. LICENSE
  26. meson.build
  27. meson_options.txt
  28. OWNERS
  29. README.md
  30. store.hpp
  31. types.hpp
  32. utilInterface.hpp
  33. vpd_exceptions.hpp
  34. vpd_tool.cpp
  35. vpd_tool_impl.cpp
  36. vpd_tool_impl.hpp
  37. write.cpp
  38. write.hpp
  39. writefru.mako.hpp
  40. writefru.py
  41. writefru.yaml
README.md

Overview

This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.