Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / 57fdd945b4a92586b446770833a8267cc0bf72d3
commit57fdd945b4a92586b446770833a8267cc0bf72d3[log] [tgz]
authorRekhaAparna01 <vrekhaaparna@ibm.com>Mon Mar 24 09:36:28 2025 -0500
committerRekhaAparna01 <vrekhaaparna@ibm.com>Mon Mar 24 12:05:38 2025 -0500
tree46d04d590e9baa9b2e7267650567d953a9edc5b1
parentcd828d48209b7c2b4aef9b099099141d88e08f48 [diff]
Fix string comparison by trimming newline char

Fixed an issue where the API isFieldModeEnabled always returns true due
to newline character at the end of the string returned from executeCmd
API. Trimmed the newline before comparison to ensure correct string
comparison.

Change-Id: I1d4aab72d062a6bfd2a6e5c21643a749366bbed5
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>
1 file changed
tree: 46d04d590e9baa9b2e7267650567d953a9edc5b1
  1. configuration/
  2. scripts/
  3. service_files/
  4. test/
  5. vpd-manager/
  6. vpd-tool/
  7. vpdecc/
  8. .clang-format
  9. .gitignore
  10. LICENSE
  11. meson.build
  12. meson_options.txt
  13. OWNERS
  14. README.md
README.md

Overview

This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.